Uploaded image for project: 'WINDUP - Red Hat Application Migration Toolkit'
  1. WINDUP - Red Hat Application Migration Toolkit
  2. WINDUP-992

org.jboss-only archive always ignored, even if --packages org.jboss is specified

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.5.0.CR3
    • Component/s: None
    • Labels:

      Description

      This commit https://github.com/windup/windup/commit/53c5fe5815 caused all my tests to start failing, because all the test classes are under the org.jboss package, so the test archives are identified as "3rd party" archives.

      This is unfortunate (and I'd call that a questionable choice, at least for Windup invocations over single archive), but I can kinda understand it. The problem is that even if I use --packages org.jboss, the archive is ignored.

      That's a bug inside the newly-introduced PackageNameMapping.isExclusivelyKnownArchive method – it calls javaConfigurationService.shouldScanFile(classname), which expects/a/file/path, but a.class.name is passed instead.

      The fix is simple (use javaConfigurationService.shouldScanPackage instead), so I'm gonna send a PR with that.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                lthon Ladislav Thon
                Reporter:
                lthon Ladislav Thon
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: