Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-4426

do not revertReloadRequired unless reload was required

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 9.0.0.Alpha1
    • Fix Version/s: 9.0.0.Beta1
    • Component/s: JMS
    • Labels:
      None

      Description

      HornetQReloadRequiredHandlers will call context.reloadRequired() if there performRuntime method is called and a HornetQ server service is installed.

      In turn, it calls context.revertReloadRequired() in their rollbackRuntime if a HornetQ server service is installed.

      However it is possible that at boot time, there is not HornetQ server installed when the performRuntime is installed (so context.reloadRequired is not called).
      Then if an operation fails at boot time and the HornetQReloadRequiredHandlers op is rolled back, there will then be an installed HornetQ server and context.revertReloadRequired() will be called.

      This generated a NPE before WFCORE-591 but it is also a programming error to call context.revertReloadRequired() in a OSH if context.reloadRequired() has not been called beforehands

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                jmesnil Jeff Mesnil
                Reporter:
                jmesnil Jeff Mesnil
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: