Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-4089

ServletContainerInitializerDeploymentProcessor does not handle comments

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 9.0.0.Beta1
    • 9.0.0.Alpha1
    • Web (Undertow)
    • None

    Description

      ServletContainerInitializerDeploymentProcessor.loadSci() has code to read the service file, rather than using the JDK-provided mechanisms, and it does not handle comments.

      The API documentation at https://docs.oracle.com/javase/7/docs/api/java/util/ServiceLoader.html says that the # symbols and all following characters on the line should be ignored. It also notes the file must be UTF-8 encoded, and ServletContainerInitializerDeploymentProcessor does not appear to force that either.

      Log4j 2.1 triggers this bug (https://issues.apache.org/jira/browse/LOG4J2-890)

      Attachments

        Activity

          People

            sdouglas1@redhat.com Stuart Douglas
            rhn-support-jlivings James Livingston (Inactive)
            Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: