Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-2879

Remove duplicated code from test cases where custom modules are needed

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 8.1.0.Final
    • Fix Version/s: 9.0.0.Alpha1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      When writing some integration tests for the PicketLink subsystem, I've noticed that there is no utility class or API to make easier create and remove custom modules from the modules directory.

      There are a few tests with this requirement, and most of them are replicating code.

      After discussing with Kabir Khan, he suggested to open this JIRA to review those test cases and make them use a reusable component to work with custom modules.

      I've already wrote a class that I think can satisfy all test cases requiring a custom module.
      See https://github.com/pedroigor/wildfly/blob/WFLY-2733/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/picketlink/util/TestModule.java.
      Usage example: https://github.com/pedroigor/wildfly/blob/WFLY-2733/testsuite/integration/basic/src/test/java/org/jboss/as/test/integration/picketlink/idm/JPAEMFFromModuleBasedPartitionManagerTestCase.java#L81

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                pcraveiro Pedro Igor
                Reporter:
                pcraveiro Pedro Igor
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: