Details
-
Feature Request
-
Resolution: Done
-
Major
-
8.0.0.CR1
-
None
Description
We have not tested the majority of subsystem transformers against AS 7.2.0. I have attempted to document why we need subsystem transformation here, and also how to use the framework:
https://docs.jboss.org/author/display/WFLY8/Domain+Mode+Subsystem+Transformers
This document is WIP, and I will be updating it a bit more over the next few days.
https://gist.github.com/kabir/6825607 contains the difference of a running WildFly instance against AS 7.2.0 in domain mode (for subsystems you don't really need to bother about this one)
https://gist.github.com/kabir/6825559 contains the difference of a running WildFly instance against AS 7.2.0 in standalone mode, here you can see what has changed in the subsystems.
When creating a new subsystem transformers test against 7.2.0, you will need the resource definition for the ModelVersion your subsystem uses in 7.2.0. If this is not found, you need to add a test to your subsystem, which you can delete once you have the .dmr file containing the resource defintion. Here is what I did to generate the file for JMX
@Test public void deleteMeWhenDone() throws Exception { ModelTestControllerVersion controllerVersion = ModelTestControllerVersion.V7_2_0_FINAL; ModelVersion modelVersion = ModelVersion.create(1, 1, 0); //Whatever version of your subsystem 7.2.0.Final has KernelServicesBuilder builder = createKernelServicesBuilder(null); builder.createLegacyKernelServicesBuilder(null, controllerVersion, modelVersion) .addMavenResourceURL("org.jboss.as:jboss-as-jmx:" + controllerVersion.getMavenGavVersion()); KernelServices services = builder.build(); generateLegacySubsystemResourceRegistrationDmr(services, modelVersion); }
Now run the test and delete it. The legacy .dmr file should be in target/test-classes/org/jboss/as/subsystem/test/<your-subsystem-name>-<your-version>.dmr. Copy this .dmr file to subsystem-test/framework/src/main/resources/org/jboss/as/subsystem/test.
You will likely also need to update org.jboss.as.subsystem.test.KnownVersions to include your latest subsystem version, once you start doing real testing.
Bear in mind that if you need to add some transformation to 7.2.0 due to some new feature in WildFly 8, you will probably also need to add the same transformation to 7.1.x as well!
Although some subsystems already have added transformers, we still need to add tests.
Attachments
Issue Links
- is related to
-
WFLY-2279 Make it possible to unintrusively be able to test transformers against legacy EAP release
- Closed