Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-11588

Audit and if possible eliminate overrides of SimpleResourceDefinition.registerCapabilities

    XMLWordPrintable

Details

    Description

      Overriding SimpleResourceDefinition.registerCapabilities is risky because if the superclass impl is not called, any caps registered in any Parameters object passed to the constructor will not be registered. Since we are tending to move using Parameters, leaving custom overrides around is a potential bug source. This is what happened with WFLY-11587.

      In many cases the registerCapabilities override is just doing what using Parameters would have done, so this task is basically to upgrade this code. If there's some specific reason why an override is still needed in some class, that's ok, but then consideration should be given to also calling the superclass impl, if it's not already being done.

      Attachments

        Issue Links

          Activity

            People

              jmesnil1@redhat.com Jeff Mesnil
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: