Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-91

Review use of Locale in toLowerCase() calls

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • Major
    • None
    • None
    • CLI, Management
    • None

    Description

      There are places where we are converting strings to lower case without specifying Locale.ENGLISH. Some of these may be fine, but some are not and they should all be reviewed:

      $ git grep "toLowerCase()"
      cli/src/main/java/org/jboss/as/cli/impl/CommandContextImpl.java:                CommandHandler handler = cmdRegistry.getCommandHandler(cmdName.toLowerCase());
      cli/src/main/java/org/jboss/as/cli/impl/CommandContextImpl.java:                CommandHandler handler = cmdRegistry.getCommandHandler(cmdName.toLowerCase());
      controller/src/main/java/org/jboss/as/controller/operations/global/ReadResourceDescriptionHandler.java:            final AccessControl value = localName != null ? MAP.get(local
      core-model-test/tests/src/test/java/org/jboss/as/core/model/test/access/RoleMappingTestCase.java:            return super.toString().toLowerCase();
      core-model-test/tests/src/test/java/org/jboss/as/core/model/test/access/RoleMappingTestCase.java:            return super.toString().toLowerCase();
      core-model-test/tests/src/test/java/org/jboss/as/core/model/test/standalone/root/StandaloneRootResourceTestCase.java:        String hostName = NetworkUtils.canonize(InetAddress
      domain-management/src/main/java/org/jboss/as/domain/management/security/adduser/ConfirmationChoice.java:            String temp = response.toLowerCase(); // We now need to matc
      domain-management/src/test/java/org/jboss/as/domain/management/security/auditlog/AbstractAuditLogHandlerTestCase.java:                PathElement.pathElement(PROTOCOL, transpor
      host-controller/src/main/java/org/jboss/as/host/controller/DirectoryGrouping.java:        final DirectoryGrouping directoryGrouping = localName != null ? MAP.get(localName.toLo
      host-controller/src/main/java/org/jboss/as/host/controller/HostControllerEnvironment.java:                qualifiedHostName = qualifiedHostName.trim().toLowerCase();
      host-controller/src/main/java/org/jboss/as/host/controller/discovery/S3Util.java:                    String lk=hashKey.toLowerCase();
      server/src/main/java/org/jboss/as/server/ServerEnvironment.java:                qualifiedHostName = qualifiedHostName.trim().toLowerCase();
      testsuite-core/domain/src/test/java/org/jboss/as/test/integration/domain/rbac/RbacSoakTest.java:            super("TestClient-" + id + " (" + type.toString().toLowerCase() + " 
      testsuite-core/domain/src/test/java/org/jboss/as/test/integration/domain/rbac/RbacSoakTest.java:            this.description = "TestClient-" + id + " (" + type.toString().toLow
      testsuite-core/shared/src/main/java/org/jboss/as/test/integration/management/interfaces/JmxInterfaceStringUtils.java:        return string.replaceAll(regex, replacement).toLowe
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            bstansbe@redhat.com Brian Stansberry
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: