Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-3905

Improve SuspendController code

    XMLWordPrintable

Details

    Description

      From Brians's comment at https://github.com/wildfly/wildfly-core/pull/3336#pullrequestreview-125435804:

      Reviewing this I see a few issues in SuspendController. 1) The Timer allocated at L98 is pointless unless timeoutMillis > 0. 2) The timeout() method can be private (same with activityPaused()). 3) The logging at L74-L78 is incorrect if timeoutMillis == 0. The "suspendingServerWithNoTimeout" message is not correct in that case as 'no timeout' doesn't mean '0 ms'.

      Attachments

        Activity

          People

            yborgess1@redhat.com Yeray Borges Santana
            jmesnil1@redhat.com Jeff Mesnil
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: