Loading...

XML

Word

Printable

Steps to Reproduce:

Hide

1. Attempt to connect via CLI.connect(...)
2. Connection fails because EAP is not running yet. CLI throws "java.lang.IllegalStateException: Unable to connect to controller"
3. Attempt to connect again.
4. CLI throws exception "java.lang.IllegalStateException: Already connected to server."
This message is incorrect. No connection has been established and should you 'accept' this fact, then any subsequent action (for example sending a command) will fail

Show
1. Attempt to connect via CLI.connect(...) 2. Connection fails because EAP is not running yet. CLI throws "java.lang.IllegalStateException: Unable to connect to controller" 3. Attempt to connect again. 4. CLI throws exception "java.lang.IllegalStateException: Already connected to server." This message is incorrect. No connection has been established and should you 'accept' this fact, then any subsequent action (for example sending a command) will fail
Estimated Difficulty:
Low
Git Pull Request:
https://github.com/wildfly/wildfly-core/pull/1501

cli/src/main/java/org/jboss/as/cli/scriptsupport/CLI.java

public void connect() {
checkAlreadyConnected();
try

{ ctx = CommandContextFactory.getInstance().newCommandContext(); ctx.connectController(); }

catch (CliInitializationException e)

{ throw new IllegalStateException("Unable to initialize command context.", e); }

catch (CommandLineException e)

{ throw new IllegalStateException("Unable to connect to controller.", e); }

}

also applicable to the other connects of course.

If the connection fails in the connect method, a subsequent connect will hit:

private void checkAlreadyConnected()

{ if (ctx != null) throw new IllegalStateException("Already connected to server."); }

and will fail for the wrong reason... as while ctx !=null is true, but the connection had failed.

ergo, upon failure in connect, the ctx should be reset to avoid this