Uploaded image for project: 'WildFly Core'
  1. WildFly Core
  2. WFCORE-1168

Incorrect null check in SimpleResourceDefinition.Parameter.setDeprecatedSince

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 2.0.4.Final
    • 2.0.3.Final
    • Management
    • None

    Description

      The null check checks the field being assigned instead of the param passed in:

              public Parameters setDeprecatedSince(ModelVersion deprecatedSince) {
                  if (deprecationData == null) { // <-- OOPS!
                      throw ControllerLogger.ROOT_LOGGER.nullVar("deprecatedSince");
                  }
      
                  this.deprecationData = new DeprecationData(deprecatedSince);
      

      The field will always be null, making this method useless.

      Attachments

        Issue Links

          Activity

            People

              bstansbe@redhat.com Brian Stansberry
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: