Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Critical
-
Resolution: Done
-
Affects Version/s: 1.1.1.Final
-
Fix Version/s: 1.1.3.SP1
-
Component/s: OSGi support
-
Labels:None
-
Environment:OSGi + SLF4J 1.6.x
-
Estimated Difficulty:Low
Description
The current weld-osgi-bundle is a bit weird in multiple ways:
- it packages slf4j 1.5.6 and at the same time imports it
- the package import definition is not a range, although incompatible API's are known already (1.5.x vs. 1.6.x)
The actual problem manifests itself e.g. in GlassFish 3.1+ with a deployed SLF4J 1.6.1:
WARNING: Failed to deploy bundle com.something.support.web [319]
|
org.glassfish.osgijavaeebase.DeploymentException: Deployment of com.something.support.web [319] failed because of following reason: Failed while deploying bundle com.something.support.web [319] : java.lang.RuntimeException: Failed to deploy bundle [ com.something.support.web [319] ], root cause: Exception while loading the app
|
at org.glassfish.osgijavaeebase.AbstractOSGiDeployer.deploy(AbstractOSGiDeployer.java:125)
|
at org.glassfish.osgijavaeebase.OSGiContainer.deploy(OSGiContainer.java:154)
|
at org.glassfish.osgijavaeebase.JavaEEExtender.deploy(JavaEEExtender.java:107)
|
at org.glassfish.osgijavaeebase.JavaEEExtender.access$200(JavaEEExtender.java:61)
|
at org.glassfish.osgijavaeebase.JavaEEExtender$HybridBundleTrackerCustomizer$1.call(JavaEEExtender.java:151)
|
at org.glassfish.osgijavaeebase.JavaEEExtender$HybridBundleTrackerCustomizer$1.call(JavaEEExtender.java:148)
|
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
|
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
|
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
|
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
|
at java.lang.Thread.run(Thread.java:662)
|
Caused by: java.lang.RuntimeException: Failed to deploy bundle [ com.something.support.web [319] ], root cause: Exception while loading the app
|
at org.glassfish.osgijavaeebase.OSGiDeploymentRequest.deploy(OSGiDeploymentRequest.java:196)
|
at org.glassfish.osgijavaeebase.OSGiDeploymentRequest.execute(OSGiDeploymentRequest.java:118)
|
at org.glassfish.osgijavaeebase.AbstractOSGiDeployer.deploy(AbstractOSGiDeployer.java:121)
|
... 10 more
|
Caused by: java.lang.NoSuchMethodError: org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V
|
at org.slf4j.cal10n.LocLogger.info(LocLogger.java:122)
|
at org.jboss.weld.bootstrap.WeldBootstrap.<clinit>(WeldBootstrap.java:213)
|
at org.glassfish.weld.WeldDeployer.load(WeldDeployer.java:345)
|
at org.glassfish.weld.WeldDeployer.load(WeldDeployer.java:99)
|
at org.glassfish.internal.data.ModuleInfo.load(ModuleInfo.java:186)
|
at org.glassfish.internal.data.ApplicationInfo.load(ApplicationInfo.java:257)
|
at com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:461)
|
at com.sun.enterprise.v3.server.ApplicationLifecycle.deploy(ApplicationLifecycle.java:240)
|
at org.glassfish.osgijavaeebase.OSGiDeploymentRequest.deploy(OSGiDeploymentRequest.java:183)
|
... 12 more
|
This introduces problems when someone deploys an application which in turn requires the SLF4J API 1.6.x.
So I suggest to fix it like this:
Import-Package:
|
...
|
org.slf4j;version="[1.5.10,1.6)";resolution:=optional,
|
org.slf4j.helpers;version="[1.5.10,1.6)";resolution:=optional,
|
org.slf4j.spi;version="[1.5.10,1.6)";resolution:=optional
|
Furthermore there are still some placeholders inside the META-INF/MANIFEST.MF:
Specification-Version: ${parsedVersion.osgiVersion}
|
Maven-Version: ${maven.version}
|
SCM: r${buildNumber}
|
The final goal should be to get rid of embedding the org.slf4j stuff altogether.
Gliffy Diagrams
Issue Links
- is blocked by
-
WELD-935
Do not deploy shaded jars like weld-servlet (as a bad replacement for weld-servlet-core) because they break dependency conflict resolution and introduce classpath issues
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
OK, I just gave a quick-shot at it.
However, can we have an updated version?
Ancoron Luciferis
added a comment - OK, I just gave a quick-shot at it.
However, can we have an updated version? What's the updated version?
I see we currently use 1.5.10. Is that OK?
I don't wanna have direct mvn dependency with range,
but I can change that bundle's import will use range.
Ales Justin
added a comment - What's the updated version?
I see we currently use 1.5.10. Is that OK?
I don't wanna have direct mvn dependency with range,
but I can change that bundle's import will use range. Hm, another postpone to 1.2? So there will be no 1.1.4 release?
I have a quite simple patch to this problem that I'm using since I filed this bug. I've updated it to the latest master:
So I would like to see a 1.1.4 release that may be used as a direct replacement for previous 1.1.x versions, e.g. in GlassFish 3.x (which depends on 1.1.2.Final currently).
Ancoron Luciferis
added a comment - Hm, another postpone to 1.2? So there will be no 1.1.4 release?
I have a quite simple patch to this problem that I'm using since I filed this bug. I've updated it to the latest master:
weld-932-master.patch
So I would like to see a 1.1.4 release that may be used as a direct replacement for previous 1.1.x versions, e.g. in GlassFish 3.x (which depends on 1.1.2.Final currently). Thank you very much! 
Ancoron Luciferis
added a comment - Thank you very much! 
There is a reason for embedding slf4j API and importing at the same time. I think that's discussed in GlassFish forum, so check there. I agree about the version range in Import-Package.