Uploaded image for project: 'Weld'
  1. Weld
  2. WELD-919

Conversation propagation token that negates the "cid" parameter

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 1.1.2.Final
    • 1.1.1.Final
    • Conversations
    • None

      A method that negates the propagation of the cid parameter by the ConversationAwareViewHandler so that a non-transient is not resumed even if there is a cid parameter in the request. Stripping it out on a per-component-basis is tricky.

      Suggested implementation: change the last line in WeldPhaseListener.getConversationId to

      return facesContext.getExternalContext().getRequestParameterMap().containsKey("nocid") ? null : cid;

            [WELD-919] Conversation propagation token that negates the "cid" parameter

            Pete Muir (Inactive) added a comment -

            Nik, make sure you add a CDI feature request as well.

            Pete Muir (Inactive) added a comment - Nik, make sure you add a CDI feature request as well.

            Ales Justin added a comment -

            Do we really want to push this kind of logic into WeldPhaseListener?

            Ales Justin added a comment - Do we really want to push this kind of logic into WeldPhaseListener?

            Nicklas Karlsson (Inactive) added a comment -

            "none" would be the default and would leave the conversation in the background to be resumed (until it would timeout) while "end" would call for an explicit end of the non-transient conversation indicated by the cid.

            Nicklas Karlsson (Inactive) added a comment - "none" would be the default and would leave the conversation in the background to be resumed (until it would timeout) while "end" would call for an explicit end of the non-transient conversation indicated by the cid.

            Ales Justin added a comment -

            What would be the diff between "none" and "end" in this case?

            Ales Justin added a comment - What would be the diff between "none" and "end" in this case?

            Nicklas Karlsson (Inactive) added a comment -

            Of course, this could be expanded in Seam2-style to name the parameter "conversationPropagation" and have values of "none" and "end" to differ between just abandoning the conversation and ending it.

            Nicklas Karlsson (Inactive) added a comment - Of course, this could be expanded in Seam2-style to name the parameter "conversationPropagation" and have values of "none" and "end" to differ between just abandoning the conversation and ending it.

              ajustin@redhat.com Ales Justin
              nickarls Nicklas Karlsson (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: