Uploaded image for project: 'Weld'
  1. Weld
  2. WELD-878

WeldPhaseListener fails to activate conversation context if conversation is not found

    XMLWordPrintable

Details

    Description

      It seems that org.jboss.weld.jsf.WeldPhaseListener fails to activate conversation context if a conversation is not found by the supplied conversation id. This problem is potentially related to [SEAMCATCH-46],WELD-855.

      JSR-299 6.7.4 Conversation context lifecycle has a requirement that 'If the propagated conversation cannot be restored, the container must associate the request with a new transient conversation and throw an exception of type javax.enterprise.context.NonexistentConversationException from the restore view phase of the JSF lifecycle.'. However, the implementation of org.jboss.weld.jsf.WeldPhaseListener.activateConversations fails to do that if a conversation is not found by the conversation id.

         private void activateConversations(FacesContext facesContext)
         {
            ConversationContext conversationContext = instance().select(HttpConversationContext.class).get();
            String cid = getConversationId(facesContext, conversationContext);
            log.debug(RESUMING_CONVERSATION, cid);
            if (cid != null && conversationContext.getConversation(cid) == null)
            {
               throw new NonexistentConversationException(NO_CONVERSATION_FOUND_TO_RESTORE, cid);
            }
            conversationContext.activate(cid);
         }
      

      Recovering from the exception becomes difficult since the context is not active. Typical symptom is 'java.lang.IllegalStateException: Unable to load current conversations from the associated request, something went badly wrong when associate() was called
      at org.jboss.weld.context.AbstractConversationContext.getCurrentConversation(AbstractConversationContext.java:413)'

      Attachments

        Activity

          People

            sdouglas1@redhat.com Stuart Douglas
            hyoty Jarkko Hyƶty (Inactive)
            Votes:
            4 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: