TorqueBox
  1. TorqueBox
  2. TORQUE-286

Cleanly detach clients from destinations

    Details

    • Type: Bug Bug
    • Status: Closed (View Workflow)
    • Priority: Major Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 1.0.0.CR1
    • Component/s: Messaging
    • Labels:
      None
    • Similar Issues:
      Show 10 results 

      Description

      When shutting down the dispatcher I assume the clients are removed cleanly from destinations, but it seems they're not:

      22:43:26,863 WARN  [org.hornetq.core.protocol.core.impl.RemotingConnectionImpl] Connection failure has been detected: Did not receive ping from /172.16.223.128:41604. It is likely the client has exited or crashed without closing its connection, or the network between the server and client has failed. The connection will now be closed. [code=3]
      22:43:26,864 WARN  [org.hornetq.core.server.impl.ServerSessionImpl] Client connection failed, clearing up resources for session 545a77f8-42ba-11e0-b9ec-9ea75080f399
      22:43:26,864 WARN  [org.hornetq.core.server.impl.ServerSessionImpl] Cleared up resources for session 545a77f8-42ba-11e0-b9ec-9ea75080f399
      22:43:26,864 WARN  [org.hornetq.core.protocol.core.ServerSessionPacketHandler] Client connection failed, clearing up resources for session 545a77f8-42ba-11e0-b9ec-9ea75080f399
      22:43:26,865 WARN  [org.hornetq.core.protocol.core.ServerSessionPacketHandler] Cleared up resources for session 545a77f8-42ba-11e0-b9ec-9ea75080f399
      22:43:26,865 WARN  [org.hornetq.core.server.impl.ServerSessionImpl] Client connection failed, clearing up resources for session 5463c6c9-42ba-11e0-b9ec-9ea75080f399
      22:43:26,980 WARN  [org.hornetq.core.server.impl.ServerSessionImpl] Cleared up resources for session 5463c6c9-42ba-11e0-b9ec-9ea75080f399
      22:43:26,981 WARN  [org.hornetq.core.protocol.core.ServerSessionPacketHandler] Client connection failed, clearing up resources for session 5463c6c9-42ba-11e0-b9ec-9ea75080f399
      22:43:26,981 WARN  [org.hornetq.core.protocol.core.ServerSessionPacketHandler] Cleared up resources for session 5463c6c9-42ba-11e0-b9ec-9ea75080f399
      

        Gliffy Diagrams

          Activity

          Hide
          Bob McWhirter added a comment -
          Show
          Bob McWhirter added a comment - GertThiel reports https://gist.github.com/850952
          Hide
          Bob McWhirter added a comment -

          In a service-only alacarte knob, I get this at undeploy time:

          16:02:23,051 WARN  [org.jboss.kernel.plugins.dependency.CreateDestroyLifecycleAction] Error during destroy for torquebox.services.trq.ManagedQueue./queues/torquebox/services.trq/backgroundable: HornetQException[errorCode=104 message=Cannot delete queue jms.queue./queues/torquebox/services.trq/backgroundable on binding jms.queue./queues/torquebox/services.trq/backgroundable - it has consumers = org.hornetq.core.postoffice.impl.LocalQueueBinding]
                  at org.hornetq.core.server.impl.HornetQServerImpl.destroyQueue(HornetQServerImpl.java:713) [:6.0.0.Final]
                  at org.hornetq.jms.server.impl.JMSServerManagerImpl.destroyQueue(JMSServerManagerImpl.java:633) [:6.0.0.Final]
                  at org.torquebox.messaging.core.ManagedQueue.destroy(ManagedQueue.java:35) [:1.0.0.CR1-SNAPSHOT]
                  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [:1.6.0_22]
                  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [:1.6.0_22]
                  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [:1.6.0_22]
                  at java.lang.reflect.Method.invoke(Method.java:597) [:1.6.0_22]
                  at org.jboss.reflect.plugins.introspection.ReflectionUtils.invoke(ReflectionUtils.java:60) [jboss-reflect.jar:2.2.0.GA]
                  at org.jboss.reflect.plugins.introspection.ReflectMethodInfoImpl.invoke(ReflectMethodInfoImpl.java:168) [jboss-reflect.jar:2.2.0.GA]
                  at org.jboss.joinpoint.plugins.BasicMethodJoinPoint.dispatch(BasicMethodJoinPoint.java:66) [jboss-reflect.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.KernelControllerContextAction$JoinpointDispatchWrapper.execute(KernelControllerContextAction.java:257) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.ExecutionWrapper.execute(ExecutionWrapper.java:47) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.KernelControllerContextAction.dispatchExecutionWrapper(KernelControllerContextAction.java:125) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.KernelControllerContextAction.dispatchJoinPoint(KernelControllerContextAction.java:72) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.LifecycleAction.uninstallActionInternal(LifecycleAction.java:286) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.InstallsAwareAction.uninstallAction(InstallsAwareAction.java:175) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.kernel.plugins.dependency.InstallsAwareAction.uninstallAction(InstallsAwareAction.java:42) [jboss-kernel.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.action.SimpleControllerContextAction.simpleUninstallAction(SimpleControllerContextAction.java:79) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.action.AccessControllerContextAction.uninstall(AccessControllerContextAction.java:131) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractControllerContextActions.uninstall(AbstractControllerContextActions.java:58) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractControllerContext.uninstall(AbstractControllerContext.java:385) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractController.uninstall(AbstractController.java:2078) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractController.uninstallContext(AbstractController.java:1624) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractController.uninstallContext(AbstractController.java:1472) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractController.uninstall(AbstractController.java:756) [jboss-dependency.jar:2.2.0.GA]
                  at org.jboss.dependency.plugins.AbstractController.uninstall(AbstractController.java:669) [jboss-dependency.jar:2.2.0.GA]
          

          Show
          Bob McWhirter added a comment - In a service-only alacarte knob, I get this at undeploy time: 16:02:23,051 WARN [org.jboss.kernel.plugins.dependency.CreateDestroyLifecycleAction] Error during destroy for torquebox.services.trq.ManagedQueue./queues/torquebox/services.trq/backgroundable: HornetQException[errorCode=104 message=Cannot delete queue jms.queue./queues/torquebox/services.trq/backgroundable on binding jms.queue./queues/torquebox/services.trq/backgroundable - it has consumers = org.hornetq.core.postoffice.impl.LocalQueueBinding] at org.hornetq.core.server.impl.HornetQServerImpl.destroyQueue(HornetQServerImpl.java:713) [:6.0.0.Final] at org.hornetq.jms.server.impl.JMSServerManagerImpl.destroyQueue(JMSServerManagerImpl.java:633) [:6.0.0.Final] at org.torquebox.messaging.core.ManagedQueue.destroy(ManagedQueue.java:35) [:1.0.0.CR1-SNAPSHOT] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [:1.6.0_22] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [:1.6.0_22] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [:1.6.0_22] at java.lang.reflect.Method.invoke(Method.java:597) [:1.6.0_22] at org.jboss.reflect.plugins.introspection.ReflectionUtils.invoke(ReflectionUtils.java:60) [jboss-reflect.jar:2.2.0.GA] at org.jboss.reflect.plugins.introspection.ReflectMethodInfoImpl.invoke(ReflectMethodInfoImpl.java:168) [jboss-reflect.jar:2.2.0.GA] at org.jboss.joinpoint.plugins.BasicMethodJoinPoint.dispatch(BasicMethodJoinPoint.java:66) [jboss-reflect.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.KernelControllerContextAction$JoinpointDispatchWrapper.execute(KernelControllerContextAction.java:257) [jboss-kernel.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.ExecutionWrapper.execute(ExecutionWrapper.java:47) [jboss-kernel.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.KernelControllerContextAction.dispatchExecutionWrapper(KernelControllerContextAction.java:125) [jboss-kernel.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.KernelControllerContextAction.dispatchJoinPoint(KernelControllerContextAction.java:72) [jboss-kernel.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.LifecycleAction.uninstallActionInternal(LifecycleAction.java:286) [jboss-kernel.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.InstallsAwareAction.uninstallAction(InstallsAwareAction.java:175) [jboss-kernel.jar:2.2.0.GA] at org.jboss.kernel.plugins.dependency.InstallsAwareAction.uninstallAction(InstallsAwareAction.java:42) [jboss-kernel.jar:2.2.0.GA] at org.jboss.dependency.plugins.action.SimpleControllerContextAction.simpleUninstallAction(SimpleControllerContextAction.java:79) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.action.AccessControllerContextAction.uninstall(AccessControllerContextAction.java:131) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractControllerContextActions.uninstall(AbstractControllerContextActions.java:58) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractControllerContext.uninstall(AbstractControllerContext.java:385) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractController.uninstall(AbstractController.java:2078) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractController.uninstallContext(AbstractController.java:1624) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractController.uninstallContext(AbstractController.java:1472) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractController.uninstall(AbstractController.java:756) [jboss-dependency.jar:2.2.0.GA] at org.jboss.dependency.plugins.AbstractController.uninstall(AbstractController.java:669) [jboss-dependency.jar:2.2.0.GA]
          Hide
          Toby Crawley added a comment -

          I was able to recreate this, with the behavior that GertThiel reported. My steps:

          • deploy an app with several tasks/queues/services (so it takes a while to start up - https://github.com/torquebox/kitchen-sink in this case)
          • before the app is fully deployed, undeploy (I'm not sure if undeploying before the deploy finishes, but it's what I did)
          • wait for undeploy to finish (I saw the 'it has consumers' stack here)
          • deploy again

          At this point, I saw what appeared to be several deploys/undeploys of the app, before it finally settled down and was fully deployed.

          log: https://gist.github.com/852949

          Show
          Toby Crawley added a comment - I was able to recreate this, with the behavior that GertThiel reported. My steps: deploy an app with several tasks/queues/services (so it takes a while to start up - https://github.com/torquebox/kitchen-sink in this case) before the app is fully deployed, undeploy (I'm not sure if undeploying before the deploy finishes, but it's what I did) wait for undeploy to finish (I saw the 'it has consumers' stack here) deploy again At this point, I saw what appeared to be several deploys/undeploys of the app, before it finally settled down and was fully deployed. log: https://gist.github.com/852949
          Hide
          Bob McWhirter added a comment -

          I continue to see this particularly during integration test runs on Win7.

          Show
          Bob McWhirter added a comment - I continue to see this particularly during integration test runs on Win7.
          Show
          Benjamin Browning added a comment - Fixed by https://github.com/torquebox/torquebox/commit/7c4beda0207fa2486955de315c6a01d212cc7ee9 and https://github.com/torquebox/torquebox/commit/dd1f9b2a8b520dac644075bdb811c1498c7a9b80 . Resolving so someone else can verify it's fixed for them as well.

            People

            • Assignee:
              Benjamin Browning
              Reporter:
              Marek Goldmann
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development