Uploaded image for project: 'Thorntail'
  1. Thorntail
  2. THORN-349

The two flavors of getImplicitDeployments() in the ServerConfiguration SPI is error-prone and confusing

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: spi_1.0.0.CR2
    • Component/s: core
    • Labels:
      None

      Description

      Since the SPI split, the 'Swarm' object isn't necessarily available.

      To that end, it implements `ArtifactLookup` from the SPI. And is passed to `getImplicitDeployments`.

      By default, the 2-arg version of `getImplicitDeployments` calls the 1-arg without the `ArtifactLookup` object.

      But some of our concrete subclasses don't handle that delegation appropriately.

      And ultimately the 2-arg version is no longer needed, sincey `ArtifactLookup.get()` is globally available for anything that needs it. No reason to pass it through as a parameter to the method.

      Therefore, we should return to the original 1-arg version, and let anyone who needs it do an `ArtifactLookup.get()` directly.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                kenfinni Ken Finnigan
                Reporter:
                bob.mcwhirter Bob McWhirter
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: