Uploaded image for project: 'ShrinkWrap'
  1. ShrinkWrap
  2. SHRINKWRAP-451

NIO2 Implementation logic incorrect for determining directories

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 1.1.2
    • Fix Version/s: 1.1.3
    • Component/s: None
    • Labels:
      None

      Description

      As reported by contributor Patrick Huy:

      While trying to use shrinkwrap as an in memory file system for testing I noticed that Files.walkFileTreePath does not work at all as

      Path dirPath = fs.getPath("dir");
       Files.createDirectory(dirPath);
       Assert.assertTrue("Created directory was not a directory", Files.isDirectory(dirPath));

      fails. Created directories are not correctly identified as such. Additionally the DirectoryStream implementation does not match what Java's implementation of walkFileTreePath expects (it returns all Files in the filesystem not just those beneath the specified path)

        Gliffy Diagrams

          Activity

          Show
          alrubinger Andrew Rubinger added a comment - Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/3319e64c455a5f0e601b19066318d28c4bea3df1

            People

            • Assignee:
              alrubinger Andrew Rubinger
              Reporter:
              alrubinger Andrew Rubinger
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development