Uploaded image for project: 'ShrinkWrap'
  1. ShrinkWrap
  2. SHRINKWRAP-226

Support Addition of an Asset to an Archive Using Name Supplied by Value Object Wrapper

    Details

      Description

      public interface NamedThingy

      { String getName(); Asset getThing(); }

      Archive.add(NamedThingy)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            alrubinger Andrew Rubinger added a comment -

            The idea here is to create a pluggable separation between an Asset and a default name whereby we can add Assets into an archive without having to explicitly supply the name (ArchivePath) each time.

            Show
            alrubinger Andrew Rubinger added a comment - The idea here is to create a pluggable separation between an Asset and a default name whereby we can add Assets into an archive without having to explicitly supply the name (ArchivePath) each time.
            Hide
            cwash Chris Wash added a comment -
            Show
            cwash Chris Wash added a comment - ALR/Pete, Is this kind of what you guys had in mind? http://github.com/cwash/shrinkwrap/commit/48b67fbf9bfcdc570299e27c3c52bd8a3634aab5
            Hide
            cwash Chris Wash added a comment -

            Pete wanted the name shortened. Added this in a recent commit. Will push when I get home and issue a pull request.

            Show
            cwash Chris Wash added a comment - Pete wanted the name shortened. Added this in a recent commit. Will push when I get home and issue a pull request.
            Hide
            alrubinger Andrew Rubinger added a comment -

            +1 on the shorter name. Also I think the test "testAddNamedAsset" should check the contents of the added asset to be sure all's in order.

            Show
            alrubinger Andrew Rubinger added a comment - +1 on the shorter name. Also I think the test "testAddNamedAsset" should check the contents of the added asset to be sure all's in order.
            Hide
            alrubinger Andrew Rubinger added a comment -

            Does the current state of:

            https://github.com/cwash/shrinkwrap/commits/SHRINKWRAP-226

            ...represent the patches in final form as you'd like 'em reviewed and put into place?

            Show
            alrubinger Andrew Rubinger added a comment - Does the current state of: https://github.com/cwash/shrinkwrap/commits/SHRINKWRAP-226 ...represent the patches in final form as you'd like 'em reviewed and put into place?

              People

              • Assignee:
                alrubinger Andrew Rubinger
                Reporter:
                alrubinger Andrew Rubinger
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development