Uploaded image for project: 'ShrinkWrap'
  1. ShrinkWrap
  2. SHRINKWRAP-218

Add multiple modules at once to EnterpriseArchive

    Details

    • Type: Feature Request
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      At the moment I can add multiple modules to EnterpriseArchiv like this:

      final EnterpriseArchive ear = ShrinkWrap.create(EnterpriseArchive.class, "test.ear")
      .addModule(ejb)
      .addModule(war)
      .addModule(ArtifactResolver.resolve("org.jboss.seam:jboss-seam:2.2.0.GA"));

      Would be nice to shorten this a bit, like this:
      final EnterpriseArchive ear = ShrinkWrap.create(EnterpriseArchive.class, "test.ear")
      .addModules(ejb, war, ArtifactResolver.resolve("org.jboss.seam:jboss-seam:2.2.0.GA"));

        Gliffy Diagrams

          Activity

          Hide
          alrubinger Andrew Rubinger added a comment -

          Would you like to work on this issue, Michael?

          Show
          alrubinger Andrew Rubinger added a comment - Would you like to work on this issue, Michael?
          Hide
          michaelschuetz Michael Schuetz added a comment -

          Yes, why not. Doesn't sound to difficult. So I need to fork github repo first and work there?

          Show
          michaelschuetz Michael Schuetz added a comment - Yes, why not. Doesn't sound to difficult. So I need to fork github repo first and work there?
          Hide
          alrubinger Andrew Rubinger added a comment -
          Show
          alrubinger Andrew Rubinger added a comment - Dev Instructions: http://community.jboss.org/docs/DOC-14304
          Hide
          aslak Aslak Knutsen added a comment -

          We should probably support that style on all overloading addModule methods that does not specify a target.

          addModules(Archive<?>... archives)
          addModules(File... files)
          addModules(String... resources)

          Show
          aslak Aslak Knutsen added a comment - We should probably support that style on all overloading addModule methods that does not specify a target. addModules(Archive<?>... archives) addModules(File... files) addModules(String... resources)
          Show
          alrubinger Andrew Rubinger added a comment - Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/7295fe5a032e2ec0077818b6473461983b642baf

            People

            • Assignee:
              alrubinger Andrew Rubinger
              Reporter:
              michaelschuetz Michael Schuetz
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development