Details
-
Type:
Feature Request
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 1.0.0-beta-3
-
Component/s: impl-base
-
Labels:None
-
Forum Reference:
Description
While working with ShrinkWrap on my tests project I have come to need of automatic creation of default MANIFEST.MF file in META-INF directory.
I would like to have it for every archive which extends ManifestContainer<?>.
So, it would work the best when it will be created at the creation of archive and in case of user add his own the default one will be overwritten.
Content of the default MANIFEST.MF could be as simple as this:
Manifest-Version: 1.0
Created-By: 1.0.0 (ShrinkWrap)
Gliffy Diagrams
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Proposal pushed to fork: https://github.com/tommysdk/shrinkwrap/commit/f5b70b51168ed3566507937e303620f21a2baaca
Tommy Tynjä
added a comment - Proposal pushed to fork: https://github.com/tommysdk/shrinkwrap/commit/f5b70b51168ed3566507937e303620f21a2baaca 
Andrew Rubinger
added a comment - Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/d3bd9e42f5535c1e34351f63c5788727c365c6c7 
A good idea to provide creation of a default manifest. But I think it should still be up to the user if the manifest should be added to the archive. Maybe we could just provide a method .addManifest() (or other appropriate name), which takes no parameters and adds a default manifest to the manifest container.