Uploaded image for project: 'ShrinkWrap'
  1. ShrinkWrap
  2. SHRINKWRAP-187

Existing folders will silently be overwritten by files

        Details

        • Workaround:
          Workaround Exists
        • Workaround Description:
          Hide

          Do not store if archive.contains(path);

          Show
          Do not store if archive.contains(path);

          Description

          Example

          archive.addResource("my-local-resource.xml", "/META-INF/my.xml") // becomes /META-INF/my.xml
          archive.addResource("my-local-resource2.xml", "/META-INF") // becomes the file META-INF, the existing Folder META-INF and sub files are deleted

          The second line could be a simple typo on the users side, but with no warning or error you have to debug the archive to even figure out what happened.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              alrubinger Andrew Rubinger added a comment -

              This operation should fail.

              Show
              alrubinger Andrew Rubinger added a comment - This operation should fail.
              Hide
              Permalink
              alrubinger Andrew Rubinger added a comment -

              Upstream:

              https://github.com/shrinkwrap/shrinkwrap/commit/eae69cc4977e12aa2c200ad36f59d091ef8b647d
              https://github.com/shrinkwrap/shrinkwrap/commit/ac2b368086a8ea70201049519889ae53eaeff744

              Show
              alrubinger Andrew Rubinger added a comment - Upstream: https://github.com/shrinkwrap/shrinkwrap/commit/eae69cc4977e12aa2c200ad36f59d091ef8b647d https://github.com/shrinkwrap/shrinkwrap/commit/ac2b368086a8ea70201049519889ae53eaeff744

                People

                • Assignee:
                  Silenius Samuel Santos
                  Reporter:
                  aslak Aslak Knutsen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development