Uploaded image for project: 'ShrinkWrap'
  1. ShrinkWrap
  2. SHRINKWRAP-179

Container.setXX methods should support the new Package construct

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 1.0.0-alpha-13
    • 1.0.0-alpha-9
    • api, impl-base
    • None

      We support this construct for adding, Container.addXX(Package, Name) adds a Named resource inside a Package

      Container.setXX() methods should support the same.

      example:

      • @param resourcePackage The package of the resource
      • @param resourceName The name of the resource inside resoucePackage

      T addManifestResource(Package resourcePackage, String resourceName) throws IllegalArgumentException;
      T addManifestResource(Package resourcePackage, String resourceName, String target) throws IllegalArgumentException;
      T addManifestResource(Package resourcePackage, String resourceName, ArchivePath target) throws IllegalArgumentException;

      addManifestResource(org.test.MyClass.class.getPackage(), "myclass.resources") -> org/test/myclass.resources

      Set should have the same capabilities:

      T setManifest(String resourceName) throws IllegalArgumentException;

      T setManifest(Package resourcePackage, String resourceName) throws IllegalArgumentException;

            [SHRINKWRAP-179] Container.setXX methods should support the new Package construct

            Andrew Rubinger (Inactive) added a comment -

            Upstream: https://github.com/shrinkwrap/shrinkwrap/pull/11

            Andrew Rubinger (Inactive) added a comment - Upstream: https://github.com/shrinkwrap/shrinkwrap/pull/11

            Davide D'Alto added a comment -

            https://github.com/DavideD/shrinkwrap/commits/SHRINKWRAP-179

            Davide D'Alto added a comment - https://github.com/DavideD/shrinkwrap/commits/SHRINKWRAP-179

            Andrew Rubinger (Inactive) added a comment -

            Can we update the description of this issue to be more informative? I'm not sure what this is asking, specifically.

            Andrew Rubinger (Inactive) added a comment - Can we update the description of this issue to be more informative? I'm not sure what this is asking, specifically.

              ddalto@redhat.com Davide D'Alto
              aslak@redhat.com Aslak Knutsen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: