Uploaded image for project: 'ShrinkWrap Resolvers'
  1. ShrinkWrap Resolvers
  2. SHRINKRES-4

Consolidate ShrinkWrap Dependency Resolver control by system properties

    Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 1.0.0-beta-6, 1.0.0-beta-7, 2.0.0-alpha-1
    • Fix Version/s: 2.0.0-alpha-5
    • Component/s: maven
    • Labels:
      None

      Description

      SystemProperty for going offline takes precedence if defined.

      The same should hold for other properties, namely this does not hold for maven.repo.local property.

        Gliffy Diagrams

          Activity

          Hide
          alrubinger Andrew Rubinger added a comment -

          Check if still present in 2.0.0-alpha-2 with a test, then resolve.

          Show
          alrubinger Andrew Rubinger added a comment - Check if still present in 2.0.0-alpha-2 with a test, then resolve.
          Hide
          alrubinger Andrew Rubinger added a comment -

          Test coverage provided by OfflineRepositoryTestCase; released in 2.0.0-alpha-2

          Show
          alrubinger Andrew Rubinger added a comment - Test coverage provided by OfflineRepositoryTestCase; released in 2.0.0-alpha-2
          Hide
          kpiwko Karel Piwko added a comment -

          This was not fixed, only offline property has its test.

          Show
          kpiwko Karel Piwko added a comment - This was not fixed, only offline property has its test.
          Show
          kpiwko Karel Piwko added a comment - Pushed upstream with test in https://github.com/shrinkwrap/resolver/commit/a47b0fd938258d016c4403240c0bbcae9389f122
          Hide
          alrubinger Andrew Rubinger added a comment -

          Note: Let's try to keep "Closed" issues as immutable; they're tied to a release. If we still need to address something, recommended practice is to clone the issue and set that to the new, desired release.

          Show
          alrubinger Andrew Rubinger added a comment - Note: Let's try to keep "Closed" issues as immutable; they're tied to a release. If we still need to address something, recommended practice is to clone the issue and set that to the new, desired release.
          Hide
          kpiwko Karel Piwko added a comment -

          Ok, I'll do that next time.

          Show
          kpiwko Karel Piwko added a comment - Ok, I'll do that next time.

            People

            • Assignee:
              kpiwko Karel Piwko
              Reporter:
              kpiwko Karel Piwko
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development