Uploaded image for project: 'ShrinkWrap Descriptors'
  1. ShrinkWrap Descriptors
  2. SHRINKDESC-54 Develop/split EE Spec and JBoss-specific descriptors in API / Impl Split
  3. SHRINKDESC-82

Attributes appearing as Elements

        Details

        • Type: Sub-task
        • Status: Closed (View Workflow)
        • Priority: Blocker
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: 1.2.0-alpha-1
        • Component/s: None
        • Labels:
          None

          Description

          For instance:

          Descriptors.create(PersistenceDescriptor.class).
          		 
                      getOrCreatePersistenceUnit().name(hibernateUnit).transactionType(txTypeJta).
          		 
                      provider(providerTypeHibernate).jtaDataSource(jtaDataSource).clazz(PersistenceDescriptor.class.getName()).up();

          ...is generating:

          <persistence>
          		 
            <persistence-unit name="hibernate-unit">
          		 
              <transaction-type>JTA</transaction-type>
          		 
              <provider>org.hibernate.ejb.HibernatePersistence</provider>
          		 
              <jta-data-source>java:/DefaultDS</jta-data-source>
          		 
              <class>org.jboss.shrinkwrap.descriptor.api.persistence20.PersistenceDescriptor</class>
          		 
            </persistence-unit>
          		 
          </persistence>

          "transaction-type" should be an attribute of the "persistence-unit" element, not an element on its own.

          Due to the autogen nature of the spec APIs from XSDs, this is likely to be reflected elsewhere as well.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              rbattenfeld Ralf Battenfeld added a comment -

              I am analyzing this. The implementation class looks ok and uses the attribute methods from the node class. I have to produce an output to see what the issue is. Metadata is also fine, it marks this field as attribute.

              Show
              rbattenfeld Ralf Battenfeld added a comment - I am analyzing this. The implementation class looks ok and uses the attribute methods from the node class. I have to produce an output to see what the issue is. Metadata is also fine, it marks this field as attribute.
              Hide
              Permalink
              alrubinger Andrew Rubinger added a comment -

              Upstream: https://github.com/shrinkwrap/descriptors/commit/da18e90e1a62fe6472e9f90f769ffb46e2f16ce8

              Show
              alrubinger Andrew Rubinger added a comment - Upstream: https://github.com/shrinkwrap/descriptors/commit/da18e90e1a62fe6472e9f90f769ffb46e2f16ce8

                People

                • Assignee:
                  rbattenfeld Ralf Battenfeld
                  Reporter:
                  alrubinger Andrew Rubinger
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development