Uploaded image for project: 'ShrinkWrap Descriptors'
  1. ShrinkWrap Descriptors
  2. SHRINKDESC-31

Descriptors clobbers file markup and formatting

        Details

        • Type: Feature Request
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: 0.1.0
        • Fix Version/s: 1.1.0-alpha-2
        • Component/s: None
        • Labels:
          None
        • Environment:
          all

          Description

          When importing a descriptor file (e.g. persistence.xml), Shrinkwrap Descriptors parses all relevant information, but also destroys all comments or other non-supported information when performing an expport. This is understandable based on the technology used, but perhaps there should be a way of merging config into an existing file that preserves as much markup as possible.

          Tough problem, but just throwing it out there.

            Gliffy Diagrams

              Issue Links

              is blocked by

              Task - A task that needs to be done. SHRINKDESC-58 Refine SPI for locking to Beta-level

              • Major - A request that should be considered seriously but is not a show stopper.
              • Closed
              is incorporated by

              Feature Request - A new feature of the product, which has yet to be developed. SHRINKDESC-25 Import / Export should be able to handle unmapped entries

              • Critical - An upcoming version that is affected by this issue cannot be released until it's addressed. A critical bug is one that crashes the application, causes loss of data or severe memory leak.
              • Closed
              relates to

              Bug - A problem which impairs or prevents the functions of the product. ARQ-410 Unable to test an archive with comments in web.xml

              • Major - A request that should be considered seriously but is not a show stopper.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                unsupported markup was fixed in SHRINKDESC-25, but still has issues with comments. They need to be handled as a special Node type.

                Show
                aslak Aslak Knutsen added a comment - unsupported markup was fixed in SHRINKDESC-25 , but still has issues with comments. They need to be handled as a special Node type.
                Hide
                Permalink
                aslak Aslak Knutsen added a comment -

                TestCase that show the import/export problem with XML Comments:
                https://github.com/aslakknutsen/descriptors/blob/SHRINKDESC-31/spi/src/test/java/org/jboss/shrinkwrap/descriptor/spi/xml/dom/XMLRoundTripTestCase.java

                Show
                aslak Aslak Knutsen added a comment - TestCase that show the import/export problem with XML Comments: https://github.com/aslakknutsen/descriptors/blob/SHRINKDESC-31/spi/src/test/java/org/jboss/shrinkwrap/descriptor/spi/xml/dom/XMLRoundTripTestCase.java
                Hide
                Permalink
                alrubinger Andrew Rubinger added a comment -

                I put this in the SHRINKDESC-58 branch for now as it intersects with some work being done there. This may be resolved when that's all merged upstream.

                https://github.com/shrinkwrap/descriptors/commit/6b12649d652cca6feb113ed0a60732fd796a5f99

                Show
                alrubinger Andrew Rubinger added a comment - I put this in the SHRINKDESC-58 branch for now as it intersects with some work being done there. This may be resolved when that's all merged upstream. https://github.com/shrinkwrap/descriptors/commit/6b12649d652cca6feb113ed0a60732fd796a5f99
                Hide
                Permalink
                alrubinger Andrew Rubinger added a comment -

                Upstream: https://github.com/shrinkwrap/descriptors/commit/e79b4a88daabd10dc58c9a6b6fc088d517389a87
                https://github.com/shrinkwrap/descriptors/commit/6b12649d652cca6feb113ed0a60732fd796a5f99

                Show
                alrubinger Andrew Rubinger added a comment - Upstream: https://github.com/shrinkwrap/descriptors/commit/e79b4a88daabd10dc58c9a6b6fc088d517389a87 https://github.com/shrinkwrap/descriptors/commit/6b12649d652cca6feb113ed0a60732fd796a5f99

                  People

                  • Assignee:
                    alrubinger Andrew Rubinger
                    Reporter:
                    lincolnthree Lincoln Baxter III
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved:

                      Development