Uploaded image for project: 'ShrinkWrap Descriptors'
  1. ShrinkWrap Descriptors
  2. SHRINKDESC-113

Move DescriptorNamespace out of the Public API

    Details

    • Type: Task
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      This needs some discussion before being done. It'd break backwards-compatibility with the 1.x series.

      DescriptorNamespace is mutable, which conflicts with the goals outlined in SHRINKDESC-21. We're not really testing its direct usage at the moment, and I wonder what reason end-users would have to be invoking its operations to muck around with the "namespace" of a domain object. Currently all descriptors are supporting its operations by extension:

      public interface WebAppDescriptor extends Descriptor, DescriptorNamespace<WebAppDescriptor>

      ...and the methods in question as defined by DescriptorNamespace are:

         public T addDefaultNamespaces();
         public T addNamespace(String name, String value);
         public List<String> getNamespaces();
         public T removeAllNamespaces();

      Note that Ralf's work in SHRINKDESC-21 also splits this into DescriptorNamespace and DescriptorMutableNamespace.

      My feeling is that neither should be part of the API; maybe SPI or just internals.

      Discuss if it's appropriate to remove this and break the backwards-compatibility with the 1.x series. In this case, I'm willing to entertain this exception.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  mmatloka Michal Matloka
                  Reporter:
                  alrubinger Andrew Rubinger
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated: