Status: Open (View Workflow)
Affects Version/s: None
Fix Version/s: None
Similar Issues:Show 10 results
SHRINKDESC-45 Import XML to generic Node structure should be public API SHRINKDESC-70 Move Descriptors Services file out of "gen" module SHRINKDESC-71 Move JavaDoc out of "gen" and into the appropriate modules. SHRINKDESC-62 Split into api-javaee, api-jboss, impl-javaee, impl-jboss SHRINKDESC-55 Move impl package "org.jboss.shrinkwrap.descriptor.example" into real tests SHRINKDESC-77 Remove JBoss Spec API dependencies SHRINKDESC-33 Descriptors API forces classloading for configuration SHRINKDESC-53 Create API/Impl Module split SHRINKDESC-73 Configure JBoss branding for API Docs SHRINKDESC-42 Split into API and Implementation modules
This needs some discussion before being done. It'd break backwards-compatibility with the 1.x series.
DescriptorNamespace is mutable, which conflicts with the goals outlined in SHRINKDESC-21. We're not really testing its direct usage at the moment, and I wonder what reason end-users would have to be invoking its operations to muck around with the "namespace" of a domain object. Currently all descriptors are supporting its operations by extension:
...and the methods in question as defined by DescriptorNamespace are:
Note that Ralf's work in SHRINKDESC-21 also splits this into DescriptorNamespace and DescriptorMutableNamespace.
My feeling is that neither should be part of the API; maybe SPI or just internals.
Discuss if it's appropriate to remove this and break the backwards-compatibility with the 1.x series. In this case, I'm willing to entertain this exception.