Uploaded image for project: 'PicketBox '
  1. PicketBox
  2. SECURITY-742

JBossPDP.evaluate() lock should be flexible

    Details

      Description

      SECURITY-418 has comments on how the re-entrant lock is creating performance issues. The evaluate method lock should be configurable - reentrant or rewrite or be lockfree.

        Gliffy Diagrams

          Activity

          Hide
          anil.saldhana Anil Saldhana added a comment - - edited

          System property picketbox.xacml.pdp.lockstrategy should be set to
          "lockfree" to disable locking or "readwrite" for ReadWriteLock.

          Show
          anil.saldhana Anil Saldhana added a comment - - edited System property picketbox.xacml.pdp.lockstrategy should be set to "lockfree" to disable locking or "readwrite" for ReadWriteLock.
          Hide
          ssadeghi Siamak Sadeghianfar added a comment -

          The readwrite lock doesn't affect the performance here since the write lock is held for the entire evaludate() method. It acts a mutual exclusion lock. The write lock should be held right when we want to update the decision caches:
          https://github.com/siamaksade/security-xacml/commit/64c7701a5b37e849576a36d2e64aaaae9210e20a

          Show
          ssadeghi Siamak Sadeghianfar added a comment - The readwrite lock doesn't affect the performance here since the write lock is held for the entire evaludate() method. It acts a mutual exclusion lock. The write lock should be held right when we want to update the decision caches: https://github.com/siamaksade/security-xacml/commit/64c7701a5b37e849576a36d2e64aaaae9210e20a

            People

            • Assignee:
              anil.saldhana Anil Saldhana
              Reporter:
              anil.saldhana Anil Saldhana
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development