Uploaded image for project: 'Seam for Apache Wicket'
  1. Seam for Apache Wicket
  2. SEAMWICKET-40

Make dependency on weld-servlet-core truly optional

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0.Final
    • Fix Version/s: None
    • Labels:
      None
    • Environment:

      An app with weld-se-core and embedded container (like embedded Jetty) running servlet/filter based web app.

      Description

      Sometimes, you may need a standalone (Java SE) application, with an optional web module.
      For project which are (for any reason, e.g. historically) not based on an app server, you would need a weld-se-core for the core.
      weld-se-core can't co-exist with weld-servlet-core because they are different impl of the same API.
      However, seam-wicket silently relies on having weld-servlet-core, at least to support RequestContext.

      I suggest to make this need
      1) explicitly stated in POM,
      2) optional.

      To make it optional, it's enough to make this block

        if( conversation.isActive() ){ ... }
      

      in SeamRequestCycleProcessor's response() optional, because without active RequestContext, it fails.

      Also, and that would be for another jira, I suggest to modify weld-servlet-core to detect presence of weld-se-core, and use it's WeldContainer instead of bootstraping a new one.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                ozizka Ondrej Zizka
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: