Uploaded image for project: 'Seam International'
  1. Seam International
  2. SEAMINTL-17

Simplify default config qualifier names for locale and time zone

        Details

        • Affects:
          Documentation (Ref Guide, User Guide, etc.)
        • Estimated Difficulty:
          Low

          Description

          The default configuration qualifiers for locale and time zone are too verbose (in an attempt to be exacting). We can loosen them up a bit for readability and to make them simpler to remember.

          I propose the following name changes for the qualifiers for default locale and timezone:

          DefaultLocaleKeyConfig --> DefaultLocale
          DefaultTimeZoneConfig --> DefaultTimeZone

          The "Key" in DefaultLocale is not needed since the type String indicates that it's a key.

          Here's the simplified user experience for configuring these values in XML:

          <beans>
          <String>
          <Produces/>
          <lc:DefaultLocale/>
          <value>fr</value>
          </String>

          <String>
          <Produces/>
          <lc:DefaultTimeZone/>
          <value>America/Denver</value>
          </String>
          </beans>

            Gliffy Diagrams

              Activity

              Hide
              Permalink
              kenfinni Ken Finnigan added a comment -

              Github commit: https://github.com/seam/international/commit/fefe13d58cd0929edf51410f05b3cc4fe9781650

              Show
              kenfinni Ken Finnigan added a comment - Github commit: https://github.com/seam/international/commit/fefe13d58cd0929edf51410f05b3cc4fe9781650

                People

                • Assignee:
                  kenfinni Ken Finnigan
                  Reporter:
                  dan.j.allen Dan Allen
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development