Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: 3.0.0.CR1
-
Fix Version/s: 3.0.0.CR2
-
Component/s: Exception Handling
-
Labels:None
Description
The fix in SEAMFACES-87 allows exceptions re-thrown by catch to be dealt with by the JSF exception handling mechanism. However, the fix for SEAMFACES-87 also swallows new exceptions generated within catch (for instance an NPE originating in the Catch handler).
Gliffy Diagrams
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Show
Brian Leathem
added a comment - https://github.com/seam/faces/commit/b858e6f82123f2f009fd8cd1db5e372008c4738f
Brian Leathem
added a comment - https://github.com/seam/faces/commit/b858e6f82123f2f009fd8cd1db5e372008c4738f Post mortem:
I tried publishing the exception into the JSF exception handling mechanism with:
} catch (Exception e)
But this resulted in a ConcurrentModificationException
So I ended up simply throwing the exception as a new RuntimeException
Show
Brian Leathem
added a comment - Post mortem:
I tried publishing the exception into the JSF exception handling mechanism with:
} catch (Exception e)
{
FacesContext ctx = FacesContext.getCurrentInstance();
ExceptionQueuedEventContext eventContext = new ExceptionQueuedEventContext(ctx, e);
eventContext.getAttributes().put("key", "value");
ctx.getApplication().publishEvent(ctx, ExceptionQueuedEvent.class, eventContext);
}
(from: http://download.oracle.com/docs/cd/E17802_01/j2ee/javaee/javaserverfaces/2.0/docs/api/javax/faces/context/ExceptionHandler.html )
But this resulted in a ConcurrentModificationException
So I ended up simply throwing the exception as a new RuntimeException
Brian Leathem
added a comment - Post mortem:
I tried publishing the exception into the JSF exception handling mechanism with:
} catch (Exception e)
{
FacesContext ctx = FacesContext.getCurrentInstance();
ExceptionQueuedEventContext eventContext = new ExceptionQueuedEventContext(ctx, e);
eventContext.getAttributes().put("key", "value");
ctx.getApplication().publishEvent(ctx, ExceptionQueuedEvent.class, eventContext);
}
(from: http://download.oracle.com/docs/cd/E17802_01/j2ee/javaee/javaserverfaces/2.0/docs/api/javax/faces/context/ExceptionHandler.html )
But this resulted in a ConcurrentModificationException
So I ended up simply throwing the exception as a new RuntimeException 
It should be trivial to compare the exception thrown within catch to the exception handled by catch, to see if it's a new exception.
Ideally this new exception would be dealt with by the JSF exception handling mechanism. Or at least have the new exception logged, and let JSF deal with the original exception.