Details
-
Type:
Feature Request
-
Status: Resolved (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: 3.0.0.Beta1
-
Fix Version/s: 3.0.0.CR1
-
Component/s: Exception Handling
-
Labels:None
-
Affects:Documentation (Ref Guide, User Guide, etc.), Interactive Demo/Tutorial
-
Git Pull Request:
Description
We need a JSF2 bridge for Catch.
Gliffy Diagrams
Issue Links
- blocks
-
SEAMFACES-23
Add exception handling
-
- Resolved
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
In your implementation I see "if (catchEvent.isHandled())". Didn't know about that. That alleviates the need log the exception, since we can feed it back to JSF to log.
Thanks
Show
Brian Leathem
added a comment - In your implementation I see "if (catchEvent.isHandled())". Didn't know about that. That alleviates the need log the exception, since we can feed it back to JSF to log.
Thanks
Brian Leathem
added a comment - In your implementation I see "if (catchEvent.isHandled())". Didn't know about that. That alleviates the need log the exception, since we can feed it back to JSF to log.
Thanks Nice, isn't it?
Again, I don't think we need to do any logging in the bridge. If it gets handled by catch, it will likely get logged or not if the developer doesn't want it to be. Anything not handled by catch will likely get logged by JSF and then thrown up to the Servlet error handler.
Show
Dan Allen
added a comment - Nice, isn't it?
Again, I don't think we need to do any logging in the bridge. If it gets handled by catch, it will likely get logged or not if the developer doesn't want it to be. Anything not handled by catch will likely get logged by JSF and then thrown up to the Servlet error handler.
Dan Allen
added a comment - Nice, isn't it?
Again, I don't think we need to do any logging in the bridge. If it gets handled by catch, it will likely get logged or not if the developer doesn't want it to be. Anything not handled by catch will likely get logged by JSF and then thrown up to the Servlet error handler. Ah, I misread what you wrote. Seems like we are on the same page 
Excellent.
Pull request satisfying complete feature request available.
Notes from IRC:
It's a matter of writing a FacesExceptionFactory and a lifecycle/navigation hook.
In other words, create a JSF exception handler that will just fire the event into Seam Catch
See:
http://weblogs.java.net/blog/edburns/archive/2009/09/03/dealing-gracefully-viewexpiredexception-jsf2