Details
-
Type:
Feature Request
-
Status: Resolved (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: 3.0.0.Alpha3
-
Fix Version/s: 3.1.0.Tracking
-
Component/s: Conversations
-
Labels:None
-
Affects:Documentation (Ref Guide, User Guide, etc.)
-
Git Pull Request:
Description
The @End annotation calls conversation.end() without first checking conversation.isTransient(). This results in exceptions when invoking the method on a transient conversation.
This should either be a configuration option of the annotation, or should not occur:
@End(ConversationPropagation.REQUIRED)
@End(ConversationPropagation.OPTIONAL)
Etc... something like that().
Gliffy Diagrams
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Added check for conversation.isTransient() on endConversation method. Properly tested, no more exception occur just debug log message "No conversation found after method".
The current behavior of @Begin is, that every invoke of that method creates a new conversation. The first invoke creates conversation id 1. The next invoke beginConversation of ConversationBoundaryInterceptor still says conversation id is null and transient. Its not possible to add a check to keep the same conversation like @Begin(join=true). The @End invoke is fine. Conversation id is set. But why is the conversation id null on beginConversation even if its invoked before?
Sebastian Sachtleben
added a comment - Added check for conversation.isTransient() on endConversation method. Properly tested, no more exception occur just debug log message "No conversation found after method".
The current behavior of @Begin is, that every invoke of that method creates a new conversation. The first invoke creates conversation id 1. The next invoke beginConversation of ConversationBoundaryInterceptor still says conversation id is null and transient. Its not possible to add a check to keep the same conversation like @Begin(join=true). The @End invoke is fine. Conversation id is set. But why is the conversation id null on beginConversation even if its invoked before? 
Similarly, @Begin should not necessarily throw an exception if a Conversation is already long-running.