Uploaded image for project: 'JBoss BRMS Platform'
  1. JBoss BRMS Platform
  2. RHBRMS-2703

Backward-incompatible change in ModifyCommand

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

    XMLWordPrintable

Details

    • Documentation (Ref Guide, User Guide, etc.), Release Notes, Compatibility/Configuration
    • RC2
    • Hide

      Marshall a org.drools.core.command.runtime.rule.ModifyCommand or just a org.drools.core.common.DisconnectedFactHandle instance.

      Show
      Marshall a org.drools.core.command.runtime.rule.ModifyCommand or just a org.drools.core.common.DisconnectedFactHandle instance.

    Description

      The fix for DROOLS-1270 seems to have changed the marshalled form of org.drools.core.command.runtime.rule.ModifyCommand in a backward-incompatible way [1]:

      • the attribute
            @XmlElement(name="fact-handle", required=true) 
            private DisconnectedFactHandle factHandle;
          

        is no more unmarshalled from a String by using the setter method setFactHandleFromString(String factHandleId). As a consequence, the org.drools.core.common.DisconnectedFactHandle cannot be unmarshalled from a XML representation such as

            <fact-handle>0:1:1134443700:1:1:DEFAULT:NON_TRAIT:null</fact-handle>
          

        rather it now requires the XML to contain marshalled DisconnectedFactHandle:

        <disconnected-fact-handle external-form="0:1:1134443700:1:1:DEFAULT:NON_TRAIT:null">
            <id>1</id>
            <identityHashCode>1134443700</identityHashCode>
            <objectHashCode>1</objectHashCode>
            <recency>1</recency>
            <entryPointId>DEFAULT</entryPointId>
            <traitType>NON_TRAIT</traitType>
        </disconnected-fact-handle>
          

      This change could potentially break (probably not very frequent) scenarios where users create the requests by themselves (not using a client nor JAXB annotated classes provided by us). On the other hand, it could be an intended change between BxMS 6.3 and 6.4, if it is the case, we should just document it.

      [1] https://github.com/droolsjbpm/drools/commit/354a92f069ade1b2564fd449838a45f174a5d41e#diff-62e4f16c72f854e4effce3188ac7e2c4R49

      Attachments

        Activity

          People

            mfusco@redhat.com Mario Fusco
            mwinkler@redhat.com Marek Winkler (Inactive)
            Archiver:
            rhn-support-ceverson Clark Everson
            Marek Winkler Marek Winkler (Inactive)
            Marek Winkler Marek Winkler (Inactive)

            Dates

              Created:
              Updated:
              Resolved:
              Archived:

              PagerDuty