Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-1641

ScrollableDataTableRenderer Emits Iframe Element with no src Attribute

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.1.4, 3.2.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      All

      Description

      The rich:scrollableDataTable is emitting a few HTML iframe elements that have no src attribute. This causes IE6, with default configuration, to post a warning to the user when running over SSL. The reason for this, per Microsoft, is that IE6 is not able to determine if the iframe is using secure or not. Although this issue does not appear to be present in IE7 and Firefox, many web application users are accessing sites (our sites) with IE6. There is a config change that can be made for IE6 to enable mixed content and avoid the warning. However, not an acceptable solution.

      You will see in the code below that the src attribute is included but later ingored when length is 0

      The code from ScrollableDataTableRenderer:

      writer.startElement("iframe", component);
      getUtils().writeAttribute(writer, "class", "dr-sdt-substrate");
      getUtils().writeAttribute(writer, "frameborder", "0");
      getUtils().writeAttribute(writer, "id", convertToString(clientId) + ":hs");
      getUtils().writeAttribute(writer, "scrolling", "no");
      getUtils().writeAttribute(writer, "src", "");
      writer.startElement("br", component);
      writer.endElement("br");
      writer.endElement("iframe");

      The code from ComponentUtils:

      public static void writeAttribute(ResponseWriter writer, String attribute, Object value ) throws IOException {
      if ( (value Unable to render embedded object: File (= null) && (value.toString().length()) not found.=0) )

      { writer.writeAttribute(attribute, value.toString(), attribute ); }

      }

      Note that there are two places where the iframe element is written in this class

        Gliffy Diagrams

          Activity

          Hide
          nbelaevski Nick Belaevski added a comment -

          Check modalPanel/calendar for valid IFRAME src value

          Show
          nbelaevski Nick Belaevski added a comment - Check modalPanel/calendar for valid IFRAME src value
          Hide
          akushunin Alexej added a comment -

          done

          Show
          akushunin Alexej added a comment - done
          Hide
          ayanul Aleksej Yanul added a comment -

          line 1759
          trunk\ui\scrollable-grid\target\classes\org\richfaces\renderkit\html\scripts\scrollable-grid.js
          trunk\ui\scrollable-grid\target\generated-component\resources\org\richfaces\renderkit\html\scripts\scrollable-grid.js

          Show
          ayanul Aleksej Yanul added a comment - line 1759 trunk\ui\scrollable-grid\target\classes\org\richfaces\renderkit\html\scripts\scrollable-grid.js trunk\ui\scrollable-grid\target\generated-component\resources\org\richfaces\renderkit\html\scripts\scrollable-grid.js

            People

            • Assignee:
              Konstantin.Mishin Konstantin Mishin
              Reporter:
              atait atait
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development