Details

      Description

      I'd like to upgrade our testing dependencies (Arquillian Core, Arquillian Drone, Selenium) but HtmlUnit needs to be upgraded from 2.12 to 2.15 first because it's a transitive dependency of Selenium.

      I upgraded it on a feature branch [1]. However, there were some problems after upgrade:

      1. HtmlUnit's API changed slightly, thise are easy fixes.
      2. DummyQueueTest is failing after HtmlUnit upgrade, it seems that it doesn't test anything (there are no asserts, only prints to console) so I removed it [2].
      3. One test in DataGridRendererTest was failing, I refactored it.
      4. Two tests in AutocompleteRendererTest were failing, I removed them because it doesn't test layout=table and these tests are already in Metamer. We might consider migrating this particular test from Metamer to the framework (as an Arquillian test). IMHO it's not worth fixing HtmlUnit test. [3]

      [1] https://github.com/richfaces/richfaces/tree/htmlunit_upgrade
      [2] https://github.com/richfaces/richfaces/commit/ebb5df8a5dfeaacc47cf4187e3a6c26bdc7d5299
      [3] https://github.com/richfaces/richfaces/commit/2a0a0ec1260ef83df2b83ba64f1d5268a8c1c710

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ppitonak Pavol Pitonak
                  Reporter:
                  ppitonak Pavol Pitonak
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - 4 hours
                    4h
                    Remaining:
                    Remaining Estimate - 4 hours
                    4h
                    Logged:
                    Time Spent - Not Specified
                    Not Specified