Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-13564

rich:pickList shows an outline when clicked

    Details

    • Type: Enhancement
    • Status: Closed (View Workflow)
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: 4.3.5
    • Fix Version/s: 4.3.7
    • Component/s: None
    • Labels:
      None
    • Sprint:
      4.3.7 Sprint 1

      Description

      Hi all, i use rich:pickList and i was amazing. If we press left button on a mouse(don't release left button) on rich:pickList we'll see rectangle. You can check it here.
      I found a solution:
      in file template "picklist.template.xml"

      ...
      <div id="#{clientId}" tabindex="-1" class="#{concatClasses('rf-pick', component.attributes['styleClass'], disabled ? component.attributes['disabledClass'] : '')}" style="#{component.attributes['style']}"
                   cdk:passThrough="onclick:onclick ondblclick:ondblclick onmousedown:onmousedown onmouseup:onmouseup onmouseover:onmouseover
                                    onmousemove:onmousemove onmouseout:onmouseout onkeypress:onkeypress onkeydown:onkeydown onkeyup:onkeyup">
      ...
      

      used tabindex attribue for DIV.
      Why?
      DIV elements are not compatible with tabindex (see the HTML 4.01 spec).
      I can create pull request .

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                bleathem Brian Leathem
                Reporter:
                alixey alexey plotnikov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 15 minutes
                  15m
                  Remaining:
                  Remaining Estimate - 15 minutes
                  15m
                  Logged:
                  Time Spent - Not Specified
                  Not Specified