Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-1263

rich:dataTable emits "rows=" attribute to rendered HTML - breaks table.rows[] DOM access via JavaScript

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.1.2
    • Fix Version/s: 3.1.3, 3.2.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      Facelets 1.1.14+Seam 2.0.0.CR3+RichFaces 3.1.2

      Description

      After upgrading from RichFaces 3.1.0 to 3.1.2, some of our client side JavaScript breaks.

      It appears that <rich:dataTable is now emitting a "rows=nnn" attribute on the generated HTML, which breaks DOM access to table.rows[nnn] (returns undefined to JavaScript because the attribute was set in HTML as a String), table.rows[ ] must be an array.

      We also noticed generated DOM differences between 3.1.0 and 3.1.2 for the table header, <th> vs. <td> in header. This change is ok, but may be related to rows= change.

        Gliffy Diagrams

          Activity

          Hide
          nbelaevski Nick Belaevski added a comment -

          remove "rows" attribute output for table

          Show
          nbelaevski Nick Belaevski added a comment - remove "rows" attribute output for table
          Hide
          sergeyhalipov Sergey Halipov added a comment -

          Fixed in trunk. Revision 3625.

          Show
          sergeyhalipov Sergey Halipov added a comment - Fixed in trunk. Revision 3625.
          Hide
          ilya_shaikovsky Ilya Shaikovsky added a comment -

          commit in 3.1.x branch and resolve to both versions please

          Show
          ilya_shaikovsky Ilya Shaikovsky added a comment - commit in 3.1.x branch and resolve to both versions please
          Hide
          sergeyhalipov Sergey Halipov added a comment -

          Done. Committed revision 3814.

          Show
          sergeyhalipov Sergey Halipov added a comment - Done. Committed revision 3814.
          Hide
          jbalunas Jay Balunas added a comment -

          Part of a bulk update, all resolutions changed to done, please review history to original resolution type

          Show
          jbalunas Jay Balunas added a comment - Part of a bulk update, all resolutions changed to done, please review history to original resolution type

            People

            • Assignee:
              nbelaevski Nick Belaevski
              Reporter:
              blazetrail Jason Anderson
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development