Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: 4.1.0.Milestone3
-
Fix Version/s: 4.1.0.Milestone4
-
Component/s: component-input
-
Labels:
-
Forum Reference:
Description
Let "[a-z].*" is expected regexp and input value is " a". The value shouldn't pass the validation, but it passes.
This can be reproduced in Metamer:
Gliffy Diagrams
Issue Links
- relates to
-
RF-11223
showcase - Some demos accepts whitespace characters as correct values for inputs, where should not, like name etc.
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
It's not just leading whitespace. Using an input value of "123a" the validation passes as well.
Brian Leathem
added a comment - It's not just leading whitespace. Using an input value of "123a" the validation passes as well. The javascript regexp interpretation is actually correct. It checks for the pattern matched within the input value, not starting with.
If you want it to start with, change the pattern to "^[a-z].*"
|
RichAutocompleteBean.java patch |
--- application/src/main/java/org/richfaces/tests/metamer/bean/rich/RichAutocompleteBean.java (revision 22827)
|
+++ application/src/main/java/org/richfaces/tests/metamer/bean/rich/RichAutocompleteBean.java (working copy)
|
@@ -170,7 +170,7 @@
|
this.value1 = value1;
|
}
|
|
- @Pattern(regexp = "[a-z].*")
|
+ @Pattern(regexp = "^[a-z].*")
|
public String getValue2() {
|
return value2;
|
}
|
Brian Leathem
added a comment - The javascript regexp interpretation is actually correct. It checks for the pattern matched within the input value, not starting with.
If you want it to start with, change the pattern to "^ [a-z] .*"
RichAutocompleteBean.java patch
--- application/src/main/java/org/richfaces/tests/metamer/bean/rich/RichAutocompleteBean.java (revision 22827)
+++ application/src/main/java/org/richfaces/tests/metamer/bean/rich/RichAutocompleteBean.java (working copy)
@@ -170,7 +170,7 @@
this.value1 = value1;
}
- @Pattern(regexp = "[a-z].*")
+ @Pattern(regexp = "^[a-z].*")
public String getValue2() {
return value2;
}
There is still the issue that when the pattern is "[a-z].*", the server and client side behave differently. There are two solutions as I see it:
- Always prepend a "^" character in the javascript regex (if it isn't already present)
- File an upstream issue with Bean Validation
Further discussion is required, I'll bring it up in the developer forums.
Brian Leathem
added a comment - There is still the issue that when the pattern is " [a-z] .*", the server and client side behave differently. There are two solutions as I see it:
Always prepend a "^" character in the javascript regex (if it isn't already present)
File an upstream issue with Bean Validation
Further discussion is required, I'll bring it up in the developer forums. Added a '^' to the beginning and a '$' to the end of the regex pattern, if they don't already exist
Brian Leathem
added a comment - Added a '^' to the beginning and a '$' to the end of the regex pattern, if they don't already exist 
The CSV behavior must the server side behavior validation behavior.