Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-11322

Metamer: rich:pickList: event handler attributes doesn't fire appropriate events

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: 4.1.0.Milestone1
    • Fix Version/s: 4.1.0.Milestone3
    • Component/s: component-selects
    • Labels:
    • Environment:
    • Steps to Reproduce:
      Hide

      Add simple JS code "alert(' An removeItem event triggered!')" to "onremoveitem" attribute, and try remove item from target list. Expected behavior is display alert, but nothing happens.
      The same behavior for rest of event handlers.

      Show
      Add simple JS code "alert(' An removeItem event triggered!')" to "onremoveitem" attribute, and try remove item from target list. Expected behavior is display alert, but nothing happens. The same behavior for rest of event handlers.

      Description

      Attributes for handling events such as onkeypress, onkeyup, onclick, onadditem, ontargetclick doesn't fire event, so nothing happens if bind some JS code to this attribute and try to trigger this event (such click, or add|remove item)

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            bleathem Brian Leathem added a comment -

            Aligned the

            {add|remove}

            items name in the @Attribute annotation with what is in the javascript

            Show
            bleathem Brian Leathem added a comment - Aligned the {add|remove} items name in the @Attribute annotation with what is in the javascript
            Hide
            ppitonak Pavol Pitonak added a comment -

            Brian,

            with latests build most of event handlers don't work, e.g. onclick, onlistclick, onsourcekeyup...

            Show
            ppitonak Pavol Pitonak added a comment - Brian, with latests build most of event handlers don't work, e.g. onclick, onlistclick, onsourcekeyup...
            Hide
            bharathnav Bharath Navali added a comment -

            Hello Pavol,

            Even I'm experiencing that onclick, onlistclick, etc are not working in 4.1.0. When can we expect these features to be fixed and working fine.

            Thanks,
            Bachchu

            Show
            bharathnav Bharath Navali added a comment - Hello Pavol, Even I'm experiencing that onclick, onlistclick, etc are not working in 4.1.0. When can we expect these features to be fixed and working fine. Thanks, Bachchu
            Hide
            jjamrich Ján Jamrich added a comment -

            According to my observations only onAddItem, onListMouseOver, onSourceMouseOver and onTargetMouseOver event handlers trigger appropriate action. Rest of event handler attributes are not working.

            Show
            jjamrich Ján Jamrich added a comment - According to my observations only onAddItem, onListMouseOver, onSourceMouseOver and onTargetMouseOver event handlers trigger appropriate action. Rest of event handler attributes are not working.
            Hide
            bleathem Brian Leathem added a comment -

            Ok, all events should be working now. Please re-open with a list of any events found not to be working.

            Show
            bleathem Brian Leathem added a comment - Ok, all events should be working now. Please re-open with a list of any events found not to be working.
            Hide
            bharathnav Bharath Navali added a comment -

            Hello Brian,

            With the latest build available for download(richfaces 4.1.0.20110805-M1) I could not see many events working. Could you please let me know how to get the latest build or else do we need to wait till 4.1.0 M2 is released. If so, when is the planned date for M2 release. Your information would be really helpful to continue with my work.

            Thanks in advance,
            Bachchu

            Show
            bharathnav Bharath Navali added a comment - Hello Brian, With the latest build available for download(richfaces 4.1.0.20110805-M1) I could not see many events working. Could you please let me know how to get the latest build or else do we need to wait till 4.1.0 M2 is released. If so, when is the planned date for M2 release. Your information would be really helpful to continue with my work. Thanks in advance, Bachchu
            Hide
            ppitonak Pavol Pitonak added a comment -

            Brian,
            there are still some event handlers not working:

            1. onsourceblur
            2. onsourcefocus
            3. ontargetblur
            4. ontargetfocus
            5. onsourcekeydown, onsourcekeyup, onsourcekeypress, ontargetkeydown, ontargetkeyup, and ontargetkeypress should be IMHO rendered in DOM on the same place as e.g. onsourceclick/ontargetclick
            6. onblur and onfocus should be IMHO rendered in DOM on the same place as e.g. onclick
            Show
            ppitonak Pavol Pitonak added a comment - Brian, there are still some event handlers not working: onsourceblur onsourcefocus ontargetblur ontargetfocus onsourcekeydown, onsourcekeyup, onsourcekeypress, ontargetkeydown, ontargetkeyup, and ontargetkeypress should be IMHO rendered in DOM on the same place as e.g. onsourceclick/ontargetclick onblur and onfocus should be IMHO rendered in DOM on the same place as e.g. onclick
            Hide
            bleathem Brian Leathem added a comment - - edited

            The focus events cannot be rendered in the DOM, because focus and blur events don't bubble up to parent elements. As such there is no way for the picklist div element to know when one of it's children have gained or lost focus. Aggregate focus/blur event hadnling muct be handled programatically.

            Similarly, the key events have specific actions for the picklist component, moving the selection up and down etc. These events must be handled problematically, and so cannot be rendered in the DOM.

            Edit: For more details on the intracasies of focus/blus event handling for the picklist, see the comments in RF-11381.

            Show
            bleathem Brian Leathem added a comment - - edited The focus events cannot be rendered in the DOM, because focus and blur events don't bubble up to parent elements. As such there is no way for the picklist div element to know when one of it's children have gained or lost focus. Aggregate focus/blur event hadnling muct be handled programatically. Similarly, the key events have specific actions for the picklist component, moving the selection up and down etc. These events must be handled problematically, and so cannot be rendered in the DOM. Edit: For more details on the intracasies of focus/blus event handling for the picklist, see the comments in RF-11381 .
            Hide
            bleathem Brian Leathem added a comment -

            The events: onsourceblur, onsourcefocus, ontargetblur, ontargetfocus, onsourcekeydown, onsourcekeyup, onsourcekeypress, ontargetkeydown, ontargetkeyup, ontargetkeypress, onblur and onfocus all work demonstrably in the dev-examples (see the feature/events branch).

            Closing this issue, as this appears to be a problem with how metamer is applying event handler updates to the component.

            A new issue should be opened to address either fixing metamer, or figuring out why the component isn't registering the dynamically changed event handlers.

            Show
            bleathem Brian Leathem added a comment - The events: onsourceblur, onsourcefocus, ontargetblur, ontargetfocus, onsourcekeydown, onsourcekeyup, onsourcekeypress, ontargetkeydown, ontargetkeyup, ontargetkeypress, onblur and onfocus all work demonstrably in the dev-examples (see the feature/events branch). Closing this issue, as this appears to be a problem with how metamer is applying event handler updates to the component. A new issue should be opened to address either fixing metamer, or figuring out why the component isn't registering the dynamically changed event handlers.

              People

              • Assignee:
                bleathem Brian Leathem
                Reporter:
                jjamrich Ján Jamrich
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development