Uploaded image for project: 'RESTEasy'
  1. RESTEasy
  2. RESTEASY-1986

SseEventOutputImpl should not log and throw

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Critical
    • 3.6.3.Final, 4.0.0.CR1
    • 3.5.1.Final, 3.6.2.Final
    • None
    • None

    Description

      SseEventOutputImpl#writeEvent() catches exceptions, logs them, then rethrows them. IMO this is a bad idea. You often don't know that the underlying channel is dead until you try to write to it, which results in useless log spam. Also, log-and-throw is an anti-pattern, and the send future will get completed with the exception anyway, so it should be the application's responsibility to check the outcome and log if it wants to.

      Attachments

        Issue Links

          Activity

            People

              rhn-support-asoldano Alessio Soldano
              rdicroce Richard DiCroce (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: