Uploaded image for project: 'RESTEasy'
  1. RESTEasy
  2. RESTEASY-1244

Resteasy swallowing Netty Http decoding exceptions

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.0.13.Final
    • Fix Version/s: 4.0.0.Beta1
    • Component/s: jaxrs
    • Labels:
      None

      Description

      When a http decoding exception like TooLongFrameException is thrown by the HttpObjectDecoder (process method), RestEasy is not checking it and processes an incompletely parsed request. The exception is not bubbling up the stack but is accessible in the message object that the request contains.

      As an example, if the header size goes beyond the limit set in NettyJaxrsServer's HttpRequestDecoder instance, it will process the headers under the limit but ignore the headers above the limit.

      I am not sure how other frameworks working on top of Netty do it, but I think Resteasy might need to check the value of request.getDecoderResult().isFailure() in RestEasyHttpRequestDecoder's decode method.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                ron_sigal Ron Sigal
                Reporter:
                iker.jimenez Iker Jimenez
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: