Details
-
Bug
-
Resolution: Done
-
Major
-
FIS 1.0 - OpenShift Fuse 3.1-GA
-
None
-
%
Description
[12:36pm] kbabo: dbokde: hey dhiraj - quick question on our s2i templates
[12:36pm] kbabo: I see a difference between the template created via the archetype
[12:37pm] kbabo: and the source as it exists upstream
[12:37pm] kbabo: the one via archetype has invalid json
[12:38pm] dbokde: kbabo: could be archetype filtering when copying resources, do you know where it's different?
[12:38pm] kbabo: yep, one sec and I'll show you
[12:38pm] kbabo: https://github.com/fabric8io/ipaas-quickstarts/blob/redhat/quickstart/java/camel-spring/quickstart-template.json#L8
[12:39pm] kbabo: the comma at the end of line 7 is missing
[12:39pm] kbabo: not in the link above
[12:39pm] kbabo: but in the generated template
[12:39pm] kbabo: I'm using this:
[12:39pm] kbabo: mvn archetype:generate -DarchetypeCatalog=http://origin-repository.jboss.org/nexus/content/groups/ea/io/fabric8/archetypes/archetypes-catalog/2.2.0.redhat-072/archetypes-catalog-2.2.0.redhat-072-archetype-catalog.xml
[12:40pm] kbabo: select [1] for java-camel-spring-archetype
[12:40pm] dbokde: that's weird, let me see what's going on, archetype generation is messing it up somehow
[1:00pm] dbokde: kbabo: looks like it's velocity used by maven archetype plugin that's messing with that file
[1:01pm] kbabo: dbokde: yeah ... the source looks good
[1:15pm] dbokde: kbabo: so, velocity treats ## in the description text as a comment and drops the rest of the description, including the ", at the end
[1:15pm] kbabo: aha!
[1:15pm] dbokde: kbabo: need to escape that in the fabric8io builder to escape that when copying json