Uploaded image for project: 'ModeShape'
  1. ModeShape
  2. MODE-1473

Second property is ignored in org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String)

    Details

      Description

      There is a bug in the method org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String):

      public EquiJoinCondition equiJoinCondition( String selector1Name,
                                                  String property1Name,
                                                  String selector2Name,
                                                  String property2Name ) {
          CheckArg.isNotNull(selector1Name, "selector1Name");
          CheckArg.isNotNull(property1Name, "property1Name");
          CheckArg.isNotNull(selector2Name, "selector2Name");
          CheckArg.isNotNull(selector2Name, "selector2Name");
          return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name);
      }
      

      where selector2Name is used as the 4th parameter to the JcrEquiJoinCondition constructor, but should be property2Name.

        Gliffy Diagrams

          Issue Links

            Activity

            dimonv Dmitri Voronov created issue -
            dimonv Dmitri Voronov made changes -
            Field Original Value New Value
            Description Hi all,

            as discribed in the forum the second parameter is ignored in the factory method JcrQueryObjectModelFactory.equiJoinCondition

            Regards
            Hi all,

            as described in the forum the second parameter is ignored in the factory method JcrQueryObjectModelFactory.equiJoinCondition

            Regards
            Forum Reference https://community.jboss.org/thread/199049 https://community.jboss.org/thread/199049
            rhauch Randall Hauch made changes -
            Fix Version/s 2.8.2.Final [ 12319498 ]
            Fix Version/s 3.0.0.Beta1 [ 12318456 ]
            Description Hi all,

            as described in the forum the second parameter is ignored in the factory method JcrQueryObjectModelFactory.equiJoinCondition

            Regards
            There is a bug in the method {{org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String)}}:
             
            {code:java}
            public EquiJoinCondition equiJoinCondition( String selector1Name,
                                                        String property1Name,
                                                        String selector2Name,
                                                        String property2Name ) {
                CheckArg.isNotNull(selector1Name, "selector1Name");
                CheckArg.isNotNull(property1Name, "property1Name");
                CheckArg.isNotNull(selector2Name, "selector2Name");
                CheckArg.isNotNull(selector2Name, "selector2Name");
                return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name);
            }
            {code}

            where {{selector2Name}} is used as the 4th parameter to the {{JcrEquiJoinCondition}} constructor, but should be {{property2Name}}.
            Forum Reference https://community.jboss.org/thread/199049 https://community.jboss.org/thread/199049
            Hide
            rhauch Randall Hauch added a comment -

            This is a simple fix. Mind tackling it?

            Show
            rhauch Randall Hauch added a comment - This is a simple fix. Mind tackling it?
            rhauch Randall Hauch made changes -
            Assignee Horia Chiorean [ hchiorean ]
            Hide
            hchiorean Horia Chiorean added a comment -

            Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.

            Show
            hchiorean Horia Chiorean added a comment - Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.
            hchiorean Horia Chiorean made changes -
            Status Open [ 1 ] Pull Request Sent [ 10011 ]
            Git Pull Request https://github.com/ModeShape/modeshape/pull/369, https://github.com/ModeShape/modeshape/pull/370
            Hide
            rhauch Randall Hauch added a comment -

            Merged both pull requests: one into '2.x' and the other into 'master'.

            Show
            rhauch Randall Hauch added a comment - Merged both pull requests: one into '2.x' and the other into 'master'.
            rhauch Randall Hauch made changes -
            Status Pull Request Sent [ 10011 ] Resolved [ 5 ]
            Fix Version/s 3.0.0.Alpha4 [ 12319296 ]
            Fix Version/s 3.0.0.Beta1 [ 12318456 ]
            Resolution Done [ 1 ]
            rhauch Randall Hauch made changes -
            Link This issue relates to MODE-1468 [ MODE-1468 ]
            rhauch Randall Hauch made changes -
            Status Resolved [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                hchiorean Horia Chiorean
                Reporter:
                dimonv Dmitri Voronov
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development