ModeShape
  1. ModeShape
  2. MODE-1473

Second property is ignored in org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String)

    Details

    • Similar Issues:
      Show 10 results 

      Description

      There is a bug in the method org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String):

      public EquiJoinCondition equiJoinCondition( String selector1Name,
                                                  String property1Name,
                                                  String selector2Name,
                                                  String property2Name ) {
          CheckArg.isNotNull(selector1Name, "selector1Name");
          CheckArg.isNotNull(property1Name, "property1Name");
          CheckArg.isNotNull(selector2Name, "selector2Name");
          CheckArg.isNotNull(selector2Name, "selector2Name");
          return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name);
      }
      

      where selector2Name is used as the 4th parameter to the JcrEquiJoinCondition constructor, but should be property2Name.

        Issue Links

          Activity

          Dmitri Voronov
          made changes -
          Field Original Value New Value
          Description Hi all,

          as discribed in the forum the second parameter is ignored in the factory method JcrQueryObjectModelFactory.equiJoinCondition

          Regards
          Hi all,

          as described in the forum the second parameter is ignored in the factory method JcrQueryObjectModelFactory.equiJoinCondition

          Regards
          Forum Reference https://community.jboss.org/thread/199049 https://community.jboss.org/thread/199049
          Randall Hauch
          made changes -
          Fix Version/s 2.8.2.Final [ 12319498 ]
          Fix Version/s 3.0.0.Beta1 [ 12318456 ]
          Description Hi all,

          as described in the forum the second parameter is ignored in the factory method JcrQueryObjectModelFactory.equiJoinCondition

          Regards
          There is a bug in the method {{org.modeshape.jcr.query.qom.JcrQueryObjectModelFactory.equiJoinCondition(String, String, String, String)}}:
           
          {code:java}
          public EquiJoinCondition equiJoinCondition( String selector1Name,
                                                      String property1Name,
                                                      String selector2Name,
                                                      String property2Name ) {
              CheckArg.isNotNull(selector1Name, "selector1Name");
              CheckArg.isNotNull(property1Name, "property1Name");
              CheckArg.isNotNull(selector2Name, "selector2Name");
              CheckArg.isNotNull(selector2Name, "selector2Name");
              return new JcrEquiJoinCondition(selectorName(selector1Name), property1Name, selectorName(selector2Name), selector2Name);
          }
          {code}

          where {{selector2Name}} is used as the 4th parameter to the {{JcrEquiJoinCondition}} constructor, but should be {{property2Name}}.
          Forum Reference https://community.jboss.org/thread/199049 https://community.jboss.org/thread/199049
          Hide
          Randall Hauch
          added a comment -

          This is a simple fix. Mind tackling it?

          Show
          Randall Hauch
          added a comment - This is a simple fix. Mind tackling it?
          Randall Hauch
          made changes -
          Assignee Horia Chiorean [ hchiorean ]
          Horia Chiorean
          02/May/12 10:37 AM
          View full commit
          MODE-1473 - Fixed parameter handling for JcrQueryObjectModelFactory.equiJoinCondition
          Horia Chiorean <hchiorea@redhat.com> committed a8a81f33f6121df6fb5eefb5f42acfa6b812c3d8 (1 file)
          Reviews: none

          MODE-1473 - Fixed parameter handling for JcrQueryObjectModelFactory.equiJoinCondition

          Horia Chiorean
          02/May/12 10:46 AM
          View full commit
          MODE-1473 - Fixed parameter handling for JcrQueryObjectModelFactory.equiJoinCondition
          Horia Chiorean <hchiorea@redhat.com> committed bba8fc596c85704c3ed92860e1db6d4c3816c4c7 (1 file)
          Reviews: none

          MODE-1473 - Fixed parameter handling for JcrQueryObjectModelFactory.equiJoinCondition

          Hide
          Horia Chiorean
          added a comment -

          Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.

          Show
          Horia Chiorean
          added a comment - Fixed the parameter handling. Added pull requests for 2.x and master, all tests pass.
          Horia Chiorean
          made changes -
          Status Open [ 1 ] Pull Request Sent [ 10011 ]
          Git Pull Request https://github.com/ModeShape/modeshape/pull/369, https://github.com/ModeShape/modeshape/pull/370
          Hide
          Randall Hauch
          added a comment -

          Merged both pull requests: one into '2.x' and the other into 'master'.

          Show
          Randall Hauch
          added a comment - Merged both pull requests: one into '2.x' and the other into 'master'.
          Randall Hauch
          made changes -
          Status Pull Request Sent [ 10011 ] Resolved [ 5 ]
          Fix Version/s 3.0.0.Alpha4 [ 12319296 ]
          Fix Version/s 3.0.0.Beta1 [ 12318456 ]
          Resolution Done [ 1 ]
          Randall Hauch
          made changes -
          Link This issue relates to MODE-1468 [ MODE-1468 ]
          Randall Hauch
          made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Horia Chiorean
              Reporter:
              Dmitri Voronov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: