Uploaded image for project: 'ModeShape'
  1. ModeShape
  2. MODE-1103

ModeShape should close the supplied input streams when importing XML

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • 2.5.0.Beta1
    • 2.4.0.Final, 2.2.1.GA
    • JCR
    • None
    • Low

    Description

      According to the JavaDoc for these methods, these methods are responsible for closing the input stream supplied as a parameter:

      • Node.setProperty(String, InputStream)
      • Property.setValue(InputStream)
      • ValueFactory.createValue(InputStream)
      • ValueFactory.createBinary(InputStream)
      • Session.importXML(String, InputStream, int)
      • Workspace.importXML(String, InputStream, int)

      (Note that the JSR-283 specification doesn't appear to require this.)

      ModeShape's implementation of all of these methods do close the stream, except for the two "importXML" methods. This needs to be corrected.

      Attachments

        Activity

          People

            rhauch Randall Hauch (Inactive)
            rhauch Randall Hauch (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: