Uploaded image for project: 'mod_cluster'
  1. mod_cluster
  2. MODCLUSTER-110

Split ModClusterServiceMBean.ping(String) into 3 methods

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 1.1.0.CR1
    • None
    • None
    • None

      Currently the ModClusterServiceMBean.ping(String) method does 3 things:
      1. If parameter is null, send a PING command that determines the accessibility/health of each proxy.
      2. If parameter is not a url, interpret the parameter as a jvm route and send a PING command that determines the accessibility of the node, configured with the specified jvm route, from each proxy.
      3. If parameter is as a url, interpret the parameter as a url and send a PING command that determines the accessibility of the node (which may or may not be configured in the proxy already) containing a connector matching the protocol, host, and port of the url, from each proxy .

      Rather than 1 multi-purpose function - this method should be split in to 3, corresponding to the 3 functions identified above:
      Map<InetSocketAddress, String> ping();
      Map<InetSocketAddress, String> ping(String jvmRoute);
      Map<InetSocketAddress, String> ping(String protocol, String host, int port);

      or perhaps:
      Map<InetSocketAddress, String> pingProxies();
      Map<InetSocketAddress, String> pingNode(String jvmRoute);
      Map<InetSocketAddress, String> pingConector(String url);

            rhn-engineering-jclere Jean-Frederic Clere
            pferraro@redhat.com Paul Ferraro
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: