Uploaded image for project: 'Log Tool'
  1. Log Tool
  2. LOGTOOL-107

jboss-logging-tools don't include the license file

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 2.1.0.Alpha1
    • None
    • None

      Not available LICENSE file in source directory structure
      Please. Added license and copyright notice.
      the fedora pakaging guideline is very strictly precise about this problem
      https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
      thanks
      regards

            [LOGTOOL-107] jboss-logging-tools don't include the license file

            James Perkins added a comment -

            The attached PR adds a LICENSE.txt file to the META-INF directory in both the source and binary JAR's.

            jperkins@localhost ~/projects/jboss/logging/jboss-logging-tools (LOGTOOL-107) $ jar tf annotations/target/jboss-logging-annotations-2.1.0.Alpha1-SNAPSHOT-sources.jar 
META-INF/MANIFEST.MF
META-INF/
org/
org/jboss/
org/jboss/logging/
org/jboss/logging/annotations/
org/jboss/logging/annotations/ConstructType.java
org/jboss/logging/annotations/Cause.java
org/jboss/logging/annotations/Once.java
org/jboss/logging/annotations/Transform.java
org/jboss/logging/annotations/Suppressed.java
org/jboss/logging/annotations/Fields.java
org/jboss/logging/annotations/Property.java
META-INF/INDEX.LIST
org/jboss/logging/annotations/FormatWith.java
org/jboss/logging/annotations/LogMessage.java
org/jboss/logging/annotations/LoggingClass.java
org/jboss/logging/annotations/MessageBundle.java
org/jboss/logging/annotations/Param.java
org/jboss/logging/annotations/ValidIdRanges.java
org/jboss/logging/annotations/Field.java
org/jboss/logging/annotations/Properties.java
org/jboss/logging/annotations/Signature.java
org/jboss/logging/annotations/Message.java
org/jboss/logging/annotations/Pos.java
org/jboss/logging/annotations/ValidIdRange.java
org/jboss/logging/annotations/MessageLogger.java
META-INF/LICENSE.txt

            If this doesn't look correct just let me know.

            James Perkins added a comment - The attached PR adds a LICENSE.txt file to the META-INF directory in both the source and binary JAR's. jperkins@localhost ~/projects/jboss/logging/jboss-logging-tools (LOGTOOL-107) $ jar tf annotations/target/jboss-logging-annotations-2.1.0.Alpha1-SNAPSHOT-sources.jar META-INF/MANIFEST.MF META-INF/ org/ org/jboss/ org/jboss/logging/ org/jboss/logging/annotations/ org/jboss/logging/annotations/ConstructType.java org/jboss/logging/annotations/Cause.java org/jboss/logging/annotations/Once.java org/jboss/logging/annotations/Transform.java org/jboss/logging/annotations/Suppressed.java org/jboss/logging/annotations/Fields.java org/jboss/logging/annotations/Property.java META-INF/INDEX.LIST org/jboss/logging/annotations/FormatWith.java org/jboss/logging/annotations/LogMessage.java org/jboss/logging/annotations/LoggingClass.java org/jboss/logging/annotations/MessageBundle.java org/jboss/logging/annotations/Param.java org/jboss/logging/annotations/ValidIdRanges.java org/jboss/logging/annotations/Field.java org/jboss/logging/annotations/Properties.java org/jboss/logging/annotations/Signature.java org/jboss/logging/annotations/Message.java org/jboss/logging/annotations/Pos.java org/jboss/logging/annotations/ValidIdRange.java org/jboss/logging/annotations/MessageLogger.java META-INF/LICENSE.txt If this doesn't look correct just let me know.

            gil cattaneo (Inactive) added a comment - - edited

            Sorry, but dont undarstand your first question.
            Fedora packaging guideline say "All program binaries and program libraries included in Fedora packages must be built from the source code that is included in the source package"
            https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
            Regards

            gil cattaneo (Inactive) added a comment - - edited Sorry, but dont undarstand your first question. Fedora packaging guideline say "All program binaries and program libraries included in Fedora packages must be built from the source code that is included in the source package" https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries Regards

            James Perkins added a comment -

            Where does the RPM look for the license? The annotations in the tooling are under ASLv2, but the annotation processor is LGPL. I just want to make sure they are put in the correct place.

            Also is there a reason why the annotations are processor would be in an RPM? Neither are used at runtime only during compile time.

            James Perkins added a comment - Where does the RPM look for the license? The annotations in the tooling are under ASLv2, but the annotation processor is LGPL. I just want to make sure they are put in the correct place. Also is there a reason why the annotations are processor would be in an RPM? Neither are used at runtime only during compile time.

              jperkins-rhn James Perkins
              puntogil gil cattaneo (Inactive)
              Archiver:
              rhn-support-sthamilt Stacey Hamilton

                Created:
                Updated:
                Resolved:
                Archived: