Uploaded image for project: 'Log Tool'
  1. Log Tool
  2. LOGTOOL-104

FQCN and an import improperly deconflicted - FQCN lost

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • Major
    • None
    • 2.0.1.Final
    • None
    • Hide

      To the org.jboss.logging.processor.generated.TransformLogger add import java.util.List; and add the following messages:

          @LogMessage
    @Message("Irrelevant typeTest1 message %s")
    void typeTest1(List list);
    
    @LogMessage
    @Message("Irrelevant typeTest2 message %s")
    void typeTest2(java.awt.List list);

      Observe the test failure at the processing level.

      Show
      To the org.jboss.logging.processor.generated.TransformLogger add import java.util.List; and add the following messages: @LogMessage @Message( "Irrelevant typeTest1 message %s" ) void typeTest1(List list); @LogMessage @Message( "Irrelevant typeTest2 message %s" ) void typeTest2(java.awt.List list); Observe the test failure at the processing level.

    Description

      Given:

      import org.osgi.framework.hooks.service.EventHook;

@MessageLogger(projectCode = "JBOSGI")
public interface FrameworkLogger extends BasicLogger {

    @LogMessage(level = WARN)
    @Message(id = 11019, value = "Error while calling event hook: %s")
    void warnErrorWhileCallingEventHook(@Cause Throwable cause, EventHook hook);

    @LogMessage(level = WARN)
    @Message(id = 11040, value = "Error while calling bundle event hook: %s")
    void warnErrorWhileCallingBundleEventHook(@Cause Throwable cause, org.osgi.framework.hooks.bundle.EventHook hook);
}

      Compilation failure:

      ERROR] COMPILATION ERROR :
      [INFO] -------------------------------------------------------------
      [ERROR] /Users/arcivanov/Documents/src/jbosgi/jbosgi-framework/core/target/generated-sources/annotations/org/jboss/osgi/framework/FrameworkLogger_$logger.java:[26,8] org.jboss.osgi.framework.FrameworkLogger_$logger is not abstract and does not override abstract method warnErrorWhileCallingBundleEventHook(java.lang.Throwable,org.osgi.framework.hooks.bundle.EventHook) in org.jboss.osgi.framework.FrameworkLogger
      [ERROR] /Users/arcivanov/Documents/src/jbosgi/jbosgi-framework/core/target/generated-sources/annotations/org/jboss/osgi/framework/FrameworkLogger_$logger.java:[336,5] method does not override or implement a method from a supertype

      Cause:

      import org.osgi.framework.hooks.service.EventHook;

@Generated(value = "org.jboss.logging.processor.generator.model.MessageLoggerImplementor", date = "2016-04-18T04:40:24-0400")
public class FrameworkLogger_$logger extends DelegatingBasicLogger implements FrameworkLogger,BasicLogger,Serializable {

    @Override
    public final void warnErrorWhileCallingEventHook(final Throwable cause, final EventHook hook) {
        super.log.logf(FQCN, org.jboss.logging.Logger.Level.WARN, cause, warnErrorWhileCallingEventHook$str(), hook);
    }

    @Override
    public final void warnErrorWhileCallingBundleEventHook(final Throwable cause, final EventHook hook) {
        super.log.logf(FQCN, org.jboss.logging.Logger.Level.WARN, cause, warnErrorWhileCallingBundleEventHook$str(), hook);
    }
}

      As you can see the cause of the failure is that EventHook argument FQCN is lost in the generated warnErrorWhileCallingBundleEventHook.

      Attachments

        Issue Links

          is incorporated by

          Component Upgrade - A task tracking an update to a bundled component or revision of component upstream of the project. LOGTOOL-118 Upgrade JDeparser from 2.0.0.Final to 2.0.2.Final

          • Blocker - To be worked above all other priorities. This term is chosen when the severity of the issue is very high, has no workaround, or the effort for the change is comparatively low. Issues that may be very publicly visible and could generate significant media attention may also drive a higher priority.
          • Resolved
          relates to

          Task - Represents a small unit of work that is not end-user facing. WELD-2237 Upgrade jboss-logging-processor to 2.0.1

          • Major - To be worked after higher priority work items are addressed. When the severity is high and the effort to change it is low to moderate, this term is chosen. Issues in this category likely have an existing workaround but implementation or execution may be non-trivial.
          • Resolved

          Activity

            People

              jperkins-rhn James Perkins
              arcivanov_jira Arcadiy Ivanov (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: