JGroups
  1. JGroups
  2. JGRP-1603

DISCARD doesn't loopback unicast messages when inserted dynamically

    Details

    • Type: Bug Bug
    • Status: Resolved Resolved (View Workflow)
    • Priority: Major Major
    • Resolution: Done
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3
    • Labels:
      None
    • Similar Issues:
      Show 10 results 

      Description

      If DISCARD isn't present in the stack on startup, it doesn't receive the SET_LOCAL_ADDRESS and it doesn't populate its localAddress. Because of this, it will discard all unicast messages, even if they're addressed to the local node.

        Activity

        Hide
        Dan Berindei
        added a comment -

        Test demonstrating the problem - it's a little more complicated than it needs to be because I thought the problem was in RSVP.

        Show
        Dan Berindei
        added a comment - Test demonstrating the problem - it's a little more complicated than it needs to be because I thought the problem was in RSVP.
        Hide
        Bela Ban
        added a comment -

        OK, I fixed DISCARD: now the local address is fetched just-in-time from JChannel if null. However, this doesn't make the test pass; only if RSVP.throw_exception_on_timeout is set to false, does it pass.
        The reason is that RSVP waits for acks from both A and B, but doesn't get one from B, and throws an exception, so we never even get to the point where we can check the response list.
        I added DynamicDiscardTest to JGroups (thanks !), the code is in master.

        Show
        Bela Ban
        added a comment - OK, I fixed DISCARD: now the local address is fetched just-in-time from JChannel if null. However, this doesn't make the test pass; only if RSVP.throw_exception_on_timeout is set to false, does it pass. The reason is that RSVP waits for acks from both A and B, but doesn't get one from B, and throws an exception, so we never even get to the point where we can check the response list. I added DynamicDiscardTest to JGroups (thanks !), the code is in master.

          People

          • Assignee:
            Bela Ban
            Reporter:
            Dan Berindei
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: