Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-3174

tx driver connection pool leak

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • 5.9.6.Final
    • Transactional Driver
    • None

    Description

      The tx driver conn pooling leaks, as

      https://github.com/jbosstm/narayana/blob/a66d5bd3ebfa96ab7e4142f28960a99b941a30e7/ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/ConnectionManager.java#L124

      if (!con.inUse() && isSameConnection(dbUrl, user, passwd, dynamic, xaDataSource, con.connectionControl()))

      is ineffective at permitting connection reuse, as isSameConnection equality requires that

      https://github.com/jbosstm/narayana/blob/a66d5bd3ebfa96ab7e4142f28960a99b941a30e7/ArjunaJTA/jdbc/classes/com/arjuna/ats/internal/jdbc/ConnectionManager.java#L181

      dynamic.equals(connControl.dynamicClass())

      which does not hold as BaseTransactionalDriverXAConnection.dynamicClass() is not overridden by DirectRecoverableConnection.

      proposed fix: make BaseTransactionalDriverXAConnection.dynamicClass() non-final, add

      @Override
      public final String dynamicClass()

      { return _dynamic; }

      to DirectRecoverableConnection. Add test coverage.

      Attachments

        Activity

          People

            Unassigned Unassigned
            rhn-engineering-jhallida Jonathan Halliday
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: