Uploaded image for project: 'JBoss Transaction Manager'
  1. JBoss Transaction Manager
  2. JBTM-2573

Can not set the right jbossts properties file when running the commitmarkable test under the codeCoverage

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.2.9.Final
    • Component/s: Testing
    • Labels:
      None

      Description

      currently the ArjunaJTA/jta commitmarkable tests fails when running under the codeCoverage. The root cause is that the jbossts properties file does not set to the "commitmarkableresourcejbossts-properties.xml".

      The surefire-plugin config the system property com.arjuna.ats.arjuna.common.propertiesFile with "jbossts-properties.xml" in the codeCoverage profile
      https://github.com/jbosstm/narayana/blob/master/pom.xml#L645

      So the https://github.com/jbosstm/narayana/blob/master/ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/commitmarkable/TestCommitMarkableResourceBase.java#L64

      resetPropertiesFile = System
      	.getProperty("com.arjuna.ats.arjuna.common.propertiesFile");
      if (resetPropertiesFile == null) {
      	System.setProperty("com.arjuna.ats.arjuna.common.propertiesFile",
      		"commitmarkableresourcejbossts-properties.xml");
      }
      

      the resetPropertiesFile does not be null and the if check statement is false, so the System.setProperty(...) can not run and the property is still the jbossts-properties.xml.

      the resetPropertiesFile could be used to revert to the origin value in the tearDown()
      https://github.com/jbosstm/narayana/blob/master/ArjunaJTA/jta/tests/classes/com/hp/mwtests/ts/jta/commitmarkable/TestCommitMarkableResourceBase.java#L79

      if (resetPropertiesFile != null) {
      	System.setProperty("com.arjuna.ats.arjuna.common.propertiesFile",
      		resetPropertiesFile);
      } else {
      	System.clearProperty("com.arjuna.ats.arjuna.common.propertiesFile");
      }
      

      This failure does not happen in the default profile as the surefire-plugin does not set this system property in the profile.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  zhfeng Zheng Feng
                  Reporter:
                  zhfeng Zheng Feng
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: