JBoss Portal
  1. JBoss Portal
  2. JBPORTAL-2182

Scripts and styles defined in *-themes.xml reordered by <p:theme />

    Details

    • Type: Feature Request Feature Request
    • Status: Resolved (View Workflow)
    • Priority: Major Major
    • Resolution: Won't Fix Won't Fix
    • Affects Version/s: 2.6.5 Final
    • Fix Version/s: None
    • Component/s: Portal Theme
    • Labels:
      None
    • Environment:
      Mac OS X
    • Similar Issues:
      Show 10 results 

      Description

      When rendering the <scripts>, <styles>, and <links> defined in *-themes.xml - the <p:theme /> tag appears to reorder the elements, specifically by placing all of the <link> tags after all of the script <tags>.

      It appears as though the PortalThemeMetaDataFactory.addChild() methods pull all of the scripts and styles separately.

      This is undesirable because theme authors should be able to control the order of their includes:

      1) Often, the order that CSS rules are included will affect how the rules are applied.
      2) The order of javascripts included can also affect behavior
      3) Rendering all of the scripts before all of the link tags can be a performance problem (see: http://developer.yahoo.com/performance/rules.html#css_top)

      This is related to: https://jira.jboss.org/jira/browse/JBPORTAL-1105

        Gliffy Diagrams

          Activity

          Hide
          Andy Pemberton added a comment -

          The script/link ordering logic is in the constructor for ThemeInfo.

          Show
          Andy Pemberton added a comment - The script/link ordering logic is in the constructor for ThemeInfo.
          Hide
          Thomas Heute added a comment -

          JBoss Portal project is EOL, it has been replaced by GateIn: https://issues.jboss.org/browse/GTNPORTAL.

          This issue won't be fixed as there will be no new version of JBoss Portal.

          Show
          Thomas Heute added a comment - JBoss Portal project is EOL, it has been replaced by GateIn: https://issues.jboss.org/browse/GTNPORTAL . This issue won't be fixed as there will be no new version of JBoss Portal.

            People

            • Assignee:
              Unassigned
              Reporter:
              Andy Pemberton
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development